fix: Reduce appInstalledEvent timeout delay#24695
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
DDDDDanica
approved these changes
May 22, 2024
vthomas13
approved these changes
May 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24695 +/- ##
========================================
Coverage 67.41% 67.41%
========================================
Files 1288 1288
Lines 50233 50233
Branches 13014 13014
========================================
Hits 33863 33863
Misses 16370 16370 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [d17b403]
Page Load Metrics (1905 ± 952 ms)
Bundle size diffs
|
Collaborator
|
Missing release label release-11.16.6 on PR. Adding release label release-11.16.6 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This improves on a flaky test. I noticed this when working on mv3 e2e tests, although I believe it is the same problem discussed here https://github.com/MetaMask/metamask-extension/pull/24016/files#r1580648050
app-installed.spec.js expects an api request to segment. It is possible for the test to get to the point where it checks for that request before the request has been made. Decreasing the timeout delay in background.js, means the request will be called sooner, in time for the test to correctly assert.
Manual testing steps
e2e tests should pass
Pre-merge author checklist
Pre-merge reviewer checklist