Skip to content

fix(devDeps): @lavamoat/allow-scripts@^3.0.1->^3.0.4#24664

Merged
legobeat merged 3 commits intoMetaMask:developfrom
legobeat:devdeps-audit-npmlog
May 21, 2024
Merged

fix(devDeps): @lavamoat/allow-scripts@^3.0.1->^3.0.4#24664
legobeat merged 3 commits intoMetaMask:developfrom
legobeat:devdeps-audit-npmlog

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented May 21, 2024 •
edited
Loading

Description

Removes transitive dependencies on deprecated node-gyp versions, npmlog.

Resolves failing npm audit.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@legobeat
devDeps: @lavamoat/allow-scripts@^3.0.1->^3.0.4
67239ff 
Removes transitive dependencies on deprecated node-gyp versions, npmlog
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 21, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added type-security dependencies Pull requests that update a dependency file team-application-security Application security team labels May 21, 2024
@socket-security
Copy link
Copy Markdown

socket-security bot commented May 21, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@gar/promisify@1.1.3, npm/@npmcli/move-file@2.0.1, npm/aproba@1.2.0, npm/are-we-there-yet@3.0.1, npm/console-control-strings@1.1.0, npm/detect-libc@1.0.3, npm/gauge@4.0.4, npm/has-unicode@2.0.1, npm/ignore-walk@3.0.1, npm/infer-owner@1.0.4, npm/needle@2.4.0, npm/node-pre-gyp@0.12.0, npm/npm-bundled@1.1.2, npm/npm-packlist@1.4.8, npm/npmlog@4.1.2, npm/os-tmpdir@1.0.2, npm/osenv@0.1.5, npm/read-package-json-fast@3.0.2, npm/sax@1.3.0, npm/wide-align@1.1.5

View full report↗︎

@legobeat legobeat changed the title devDeps: @lavamoat/allow-scripts@^3.0.1->^3.0.4 fix(devDeps): @lavamoat/allow-scripts@^3.0.1->^3.0.4 May 21, 2024
@legobeat legobeat marked this pull request as ready for review May 21, 2024 00:14
@legobeat legobeat requested review from a team as code owners May 21, 2024 00:14
This was referenced May 21, 2024
Merged
Merged
@legobeat legobeat force-pushed the devdeps-audit-npmlog branch 3 times, most recently from ee74e32 to 1ed9a15 Compare May 21, 2024 02:29
@legobeat legobeat force-pushed the devdeps-audit-npmlog branch from 1ed9a15 to 2a22bad Compare May 21, 2024 02:48
@legobeat legobeat merged commit 640cad4 into MetaMask:develop May 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
@legobeat legobeat deleted the devdeps-audit-npmlog branch May 21, 2024 07:00
@benjisclowder benjisclowder added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kumavis kumavis kumavis approved these changes

+1 more reviewer

@danjm danjm danjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-application-security Application security team type-security

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@legobeat @kumavis @danjm @benjisclowder