Skip to content

cherry-pick: bumps MMI packages (#24581)#24630

Merged
danjm merged 2 commits intoVersion-v11.17.0from
Version-v11.17.0-cherry-pick-mmi-packaages-update
May 21, 2024
Merged

cherry-pick: bumps MMI packages (#24581)#24630
danjm merged 2 commits intoVersion-v11.17.0from
Version-v11.17.0-cherry-pick-mmi-packaages-update

Conversation

@zone-live
Copy link
Copy Markdown
Contributor

@zone-live zone-live commented May 20, 2024

Description

No outstanding conflicts.

Cherry picks commit: 4cf7e80
Pull request: #24581

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

A few packages updates for MMI.

Fixes:

1. Go to this page...
2.
3.

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link
Copy Markdown

socket-security bot commented May 20, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask-institutional/custody-keyring@1.1.1

View full report↗︎

@zone-live
Copy link
Copy Markdown
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

Policies updated

@zone-live zone-live marked this pull request as ready for review May 21, 2024 08:54
@zone-live zone-live requested review from a team as code owners May 21, 2024 08:54
@zone-live zone-live added the mmi DEPRECATED: The product got sunset label May 21, 2024
@zone-live zone-live requested a review from danjm May 21, 2024 09:19
@danjm danjm merged commit 7d4dcd4 into Version-v11.17.0 May 21, 2024
@danjm danjm deleted the Version-v11.17.0-cherry-pick-mmi-packaages-update branch May 21, 2024 11:21
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-11.17.0 on PR, as PR was cherry-picked in branch 11.17.0.

@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

mmi DEPRECATED: The product got sunset release-12.0.0 Issue or pull request that will be included in release 12.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants