Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24620 +/- ##
===========================================
- Coverage 67.40% 67.37% -0.02%
===========================================
Files 1289 1289
Lines 50248 50221 -27
Branches 13011 13005 -6
===========================================
- Hits 33865 33835 -30
- Misses 16383 16386 +3 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [250d7a9]
Page Load Metrics (294 ± 326 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
approved these changes
May 21, 2024
Contributor
|
LGTM ! Smooth fix ! |
hjetpoluru
approved these changes
May 21, 2024
Collaborator
Builds ready [c811dff]
Page Load Metrics (944 ± 519 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [c25104e]
Page Load Metrics (1241 ± 564 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When you try to import an ERC20, it will require clicking on the next button twice before moving to the confirmation modal.
You will also see this error in the console:
SES_UNHANDLED_REJECTION: Error: Invariant failed: A state mutation was detected between dispatches, in the path 'metamask.tokenList.0x0000000000300dd8b0230efcfef136ecdf6abcde.unlisted'. This may cause incorrect behavior. (https://redux.js.org/style-guide/style-guide#do-not-mutate-state)(see video)I used spread operator to update the "unlisted" value in tokens instead of changing its value directly.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2024-05-20.at.14.00.53.mov
After
Screen.Recording.2024-05-20.at.14.06.11.mov
Pre-merge author checklist
Pre-merge reviewer checklist