Skip to content

cherry-pick: fix newline display in signature request content#24553

Merged
jpuri merged 1 commit intoVersion-v11.17.0from
signature_request_newline_fix
May 20, 2024
Merged

cherry-pick: fix newline display in signature request content#24553
jpuri merged 1 commit intoVersion-v11.17.0from
signature_request_newline_fix

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented May 16, 2024

Description

Newline is not preserved in re-designed signature pages.

Related issues

Fixes: #24480

Manual testing steps

  1. To to test DAPP
  2. Submit a signature request with new lines
  3. Ensure that new lines are preserved

Screenshots/Recordings

Screenshot 2024-05-13 at 4 20 06 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri requested review from a team as code owners May 16, 2024 09:23
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri merged commit 3d5798d into Version-v11.17.0 May 20, 2024
@jpuri jpuri deleted the signature_request_newline_fix branch May 20, 2024 10:41
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2024
@jpuri jpuri added the epic label May 20, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-11.17.0 on PR, as PR was cherry-picked in branch 11.17.0.

@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

epic release-12.0.0 Issue or pull request that will be included in release 12.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants