Skip to content

fix: (cherry-pick Version v11.17.0) Fix confirmation redesign disabled "Confirm" button with 16px or less scroll buffer#24527

Merged
danjm merged 1 commit intoVersion-v11.17.0from
Version-v11.17.0-cherry-pickfix-confirm-redesign-disabled-confirm-with-16px-or-less-scroll-buffer
May 20, 2024
Merged

fix: (cherry-pick Version v11.17.0) Fix confirmation redesign disabled "Confirm" button with 16px or less scroll buffer#24527
danjm merged 1 commit intoVersion-v11.17.0from
Version-v11.17.0-cherry-pickfix-confirm-redesign-disabled-confirm-with-16px-or-less-scroll-buffer

Conversation

@digiwand
Copy link
Copy Markdown
Contributor

@digiwand digiwand commented May 14, 2024

Description

Cherry-pick 0e775fd (#24489) into v11.17.0

Open in GitHub Codespaces

Related issues

Fixes: #24485

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…Bottom button with 16px or less scroll buffer (#24489)

## **Description**

- Removes 16px buffer
- Allow optional scroll buffer in useScrollRequired hook

## **Related issues**

Fixes: #24485

## **Manual testing steps**

1. Create sign request from OpenSea login
2. Observe scroll behavior 

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**


https://github.com/MetaMask/metamask-extension/assets/20778143/1b436528-b285-41c0-a365-98ce2aed7eec

### **After**


https://github.com/MetaMask/metamask-extension/assets/20778143/4a42022a-1473-4f9c-b3a5-459510f221c2

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@digiwand digiwand requested review from a team as code owners May 14, 2024 17:37
@digiwand digiwand added the team-confirmations Push issues to confirmations team label May 14, 2024
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand digiwand changed the title Version v11.17.0 cherry pickfix confirm redesign disabled confirm with 16px or less scroll buffer cherrypick: Version v11.17.0 Fix confirmation redesign disabled "Confirm" button with 16px or less scroll buffer May 14, 2024
@digiwand digiwand changed the base branch from develop to Version-v11.17.0 May 14, 2024 17:38
@digiwand digiwand changed the title cherrypick: Version v11.17.0 Fix confirmation redesign disabled "Confirm" button with 16px or less scroll buffer fix: (cherry-pick Version v11.17.0) Fix confirmation redesign disabled "Confirm" button with 16px or less scroll buffer May 14, 2024
@danjm danjm merged commit f162192 into Version-v11.17.0 May 20, 2024
@danjm danjm deleted the Version-v11.17.0-cherry-pickfix-confirm-redesign-disabled-confirm-with-16px-or-less-scroll-buffer branch May 20, 2024 13:45
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2024
@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Signatures redesign - confirm button is disabled even if full content is visible and no scroll arrow is shown

4 participants