Skip to content

fix: confirmation page not loading if re-design is enabled#24519

Merged
jpuri merged 2 commits intodevelopfrom
redesign_fix
May 16, 2024
Merged

fix: confirmation page not loading if re-design is enabled#24519
jpuri merged 2 commits intodevelopfrom
redesign_fix

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented May 14, 2024

Description

fix: confirmation page not loading if re-design is enabled

Related issues

Fixes: #24510

Manual testing steps

  1. Build the wallet yarn dist or yarn start with the feature flag on ENABLE_CONFIRMATION_REDESIGN
  2. Start a tx
  3. After adding a recipient and amount, proceed to the next screen
  4. Confirmation page opens successfully

Screenshots/Recordings

Screenshot 2024-05-14 at 7 16 29 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) confirmation-redesign team-confirmations Push issues to confirmations team labels May 14, 2024
@jpuri jpuri requested review from a team as code owners May 14, 2024 13:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 14, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 14, 2024

Builds ready [ef625a2]
Page Load Metrics (1200 ± 740 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint751771173517
domContentLoaded107024157
load57377212001542740
domInteractive107024157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@digiwand
Copy link
Copy Markdown
Contributor

digiwand commented May 15, 2024

cc: @pedronfigueiredo for visibility

@jpuri jpuri merged commit a474aa3 into develop May 16, 2024
@jpuri jpuri deleted the redesign_fix branch May 16, 2024 08:40
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 16, 2024
@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

+1 more reviewer

@digiwand digiwand digiwand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

confirmation-redesign release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-confirmations Push issues to confirmations team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Internal Bug]: Send - Sending a tx breaks the wallet with error ConfirmationInfoComponentMap [(intermediate value) is not a function

5 participants

@jpuri @metamaskbot @digiwand @pedronfigueiredo @gauthierpetetin