Skip to content

fix: Make ConnectAccountToast respect setting for multichain#24474

Merged
darkwing merged 2 commits intodevelopfrom
respect-unconnected-account-settings
May 10, 2024
Merged

fix: Make ConnectAccountToast respect setting for multichain#24474
darkwing merged 2 commits intodevelopfrom
respect-unconnected-account-settings

Conversation

@darkwing
Copy link
Copy Markdown
Contributor

@darkwing darkwing commented May 10, 2024 •
edited
Loading

Description

The toast for connecting an unconnected account on a given dapp can be turned on and off via settings toggle. Presently the toast always displays regardless of the setting, so this PR makes the toast respect the user setting.

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

  1. Make sure MetaMask has 2 accounts; be on Account 1
  2. Go to MetaMask Portfolio dapp, connect Account 1
  3. Open MetaMask and switch to Account 2
  4. See the "Connect this account?" toast
  5. Click the three-dot menu, choose "Settings", and click "Alerts"
  6. Toggle off the "Browsing a website with an unconnected account selected" setting
  7. Return to the home screen
  8. No longer see the toast

Screenshots/Recordings

Before

(the toast always displays)

After

Screen.Recording.2024-05-09.at.11.03.43.PM.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner May 10, 2024 04:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 10, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing added team-core-extension-ux Core Extension UX team needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels May 10, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 10, 2024

Builds ready [611168a]
Page Load Metrics (1405 ± 721 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint621851053517
domContentLoaded10281563
load51402214051501721
domInteractive10281563
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 53 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented May 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.44%. Comparing base (fa150dc) to head (423a52c).
Report is 4 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #24474      +/-   ##
===========================================
- Coverage    67.44%   67.44%   -0.00%     
===========================================
  Files         1286     1286              
  Lines        50137    50139       +2     
  Branches     13006    13007       +1     
===========================================
+ Hits         33812    33813       +1     
- Misses       16325    16326       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 10, 2024

Builds ready [423a52c]
Page Load Metrics (1068 ± 661 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint63148892311
domContentLoaded9411373
load51321510681376661
domInteractive9411373
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 53 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

vthomas13
vthomas13 approved these changes May 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@vthomas13 vthomas13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! LGTM

@darkwing darkwing merged commit cfcbd1e into develop May 10, 2024
@darkwing darkwing deleted the respect-unconnected-account-settings branch May 10, 2024 19:00
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 23, 2024

Missing release label release-11.17.0 on PR. Adding release label release-11.17.0 on PR and removing other release labels(release-11.18.0), as PR was added to branch 11.17.0 when release was cut.

@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@bergeron bergeron bergeron approved these changes

@vthomas13 vthomas13 vthomas13 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@darkwing @metamaskbot @bergeron @vthomas13 @gauthierpetetin