chore: removing deprecated unused site icon component from codebase#24411
Merged
georgewrmarshall merged 1 commit intodevelopfrom May 8, 2024
Merged
chore: removing deprecated unused site icon component from codebase#24411georgewrmarshall merged 1 commit intodevelopfrom
georgewrmarshall merged 1 commit intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24411 +/- ##
===========================================
- Coverage 67.36% 67.34% -0.01%
===========================================
Files 1282 1281 -1
Lines 50011 50007 -4
Branches 12983 12982 -1
===========================================
- Hits 33685 33677 -8
- Misses 16326 16330 +4 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [1efae90]
Page Load Metrics (168 ± 224 ms)
Bundle size diffs
|
garrettbear
approved these changes
May 8, 2024
Contributor
garrettbear
left a comment
There was a problem hiding this comment.
🪦 RIP site icon - LGTM
Collaborator
|
Missing release label release-11.17.0 on PR. Adding release label release-11.17.0 on PR and removing other release labels(release-11.18.0), as PR was added to branch 11.17.0 when release was cut. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR focuses on cleaning up the codebase by removing the unused
SiteIconcomponent. TheSiteIconcomponent, initially intended for displaying website icons it has been deprecated in favor ofAvatarFavicon. The removal of this component's code will streamline the codebase, reduce clutter, and improve maintainability by eliminating dead code. This cleanup effort aligns with our ongoing initiatives to replace deprecated components with design system components in the MetaMask extension's codebase for better accessibility, performance and design system alignment.Related issues
Part of: #20459
Manual testing steps
To ensure no instances of the
SiteIconcomponent remain:SiteIcon,site iconandsite-iconin the codebase.Screenshots/Recordings
After
Search in code base for site icon returns no results
Pre-merge author checklist
SiteIconcomponent does not introduce any regressions or errors.Pre-merge reviewer checklist
SiteIconcomponent is justified and does not affect the application's functionality.