feat: add support to handle blocking alerts in the alert modal#24400
Merged
vinistevam merged 168 commits intodevelopfrom May 22, 2024
Merged
feat: add support to handle blocking alerts in the alert modal#24400vinistevam merged 168 commits intodevelopfrom
vinistevam merged 168 commits intodevelopfrom
Conversation
…lert-modal-component
…lert-modal-component
…ne-alert-info-row-component
…ne-alert-info-row-component
…al.tsx Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
…al.tsx Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
…al.test.tsx Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
…lert-modal-component
…/alert-modal-handle-blocking-alert
7 tasks
…port-dynamic-actions-alert-modal
…/alert-modal-handle-blocking-alert
Collaborator
Builds ready [397a652]
Page Load Metrics (1394 ± 637 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
7 tasks
…/alert-modal-handle-blocking-alert
…/alert-modal-handle-blocking-alert
Base automatically changed from
feat/add-support-dynamic-actions-alert-modal
to
develop
May 22, 2024 13:21
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24400 +/- ##
========================================
Coverage 67.42% 67.42%
========================================
Files 1295 1295
Lines 50378 50382 +4
Branches 13047 13049 +2
========================================
+ Hits 33964 33968 +4
Misses 16414 16414 ☔ View full report in Codecov by Sentry. |
jpuri
approved these changes
May 22, 2024
digiwand
approved these changes
May 22, 2024
Collaborator
Builds ready [0918474]
Page Load Metrics (1235 ± 560 ms)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add support to handle blocking alerts to the
AlertModalcomponent.Changes:
isBlockingGot itbutton and acknowledgement checkbox for blocking alertsContext
Conceptually, some alerts cannot be acknowledged or skipped since they indicate the relevant process cannot continue. For example, having an insufficient balance to cover the gas fees for a transaction.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2411
Manual testing steps
The alert modal is currently not in use and is not available to users. It is part of the new alert system, and we will have a dedicated PR to integrate this component into the new confirmation screens.
Screenshots/Recordings
blocking-alert.webm
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist