Skip to content

chore: remove outdated mentions of removed scripts/account-import-strategies#24380

Merged
legobeat merged 1 commit intoMetaMask:developfrom
legobeat:fix-account-import-strategies-comment
May 28, 2024
Merged

chore: remove outdated mentions of removed scripts/account-import-strategies#24380
legobeat merged 1 commit intoMetaMask:developfrom
legobeat:fix-account-import-strategies-comment

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented May 5, 2024 •
edited by github-actions bot
Loading

Description

The directory was removed in #19815. This updates mentions in comment and configuration

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added the team-application-security Application security team label May 5, 2024
@legobeat legobeat marked this pull request as ready for review May 5, 2024 23:19
@legobeat legobeat requested review from a team and kumavis as code owners May 5, 2024 23:19
@legobeat legobeat force-pushed the fix-account-import-strategies-comment branch 23 times, most recently from e84454f to 0b8782c Compare May 6, 2024 07:59
@legobeat legobeat force-pushed the fix-account-import-strategies-comment branch 28 times, most recently from 6d6588b to d826dbc Compare May 7, 2024 21:53
mcmire
mcmire approved these changes May 28, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mcmire mcmire mcmire approved these changes

@mikesposito mikesposito mikesposito approved these changes

@cryptodev-2s cryptodev-2s Awaiting requested review from cryptodev-2s

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

Assignees

No one assigned

Labels

release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-application-security Application security team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@legobeat @mcmire @mikesposito @benjisclowder