Skip to content

fix: Removed the skip from the test for vault decryption#24308

Merged
hjetpoluru merged 1 commit intoVersion-v11.15.0from
enable_vault_decryption_test
Apr 30, 2024
Merged

fix: Removed the skip from the test for vault decryption#24308
hjetpoluru merged 1 commit intoVersion-v11.15.0from
enable_vault_decryption_test

Conversation

@hjetpoluru
Copy link
Copy Markdown
Contributor

@hjetpoluru hjetpoluru commented Apr 30, 2024 •
edited
Loading

Description

This PR is to enable the test vault decryption in the release v11.15.0

Open in GitHub Codespaces

Manual testing steps

This test should pass in the CircleCI

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@hjetpoluru hjetpoluru added the team-extension-platform Extension Platform team label Apr 30, 2024
@hjetpoluru hjetpoluru requested a review from danjm April 30, 2024 13:52
@hjetpoluru hjetpoluru self-assigned this Apr 30, 2024
@hjetpoluru hjetpoluru requested a review from a team as a code owner April 30, 2024 13:52
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 30, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 30, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 30, 2024

Builds ready [4fda00a]
Page Load Metrics (757 ± 449 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5413596189
domContentLoaded85728136
load432258757935449
domInteractive85728136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -73 Bytes (-0.00%)
  • ui: 658 Bytes (0.01%)
  • common: 361 Bytes (0.01%)

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.55%. Comparing base (5fcacae) to head (4fda00a).
Report is 2 commits behind head on Version-v11.15.0.

Additional details and impacted files 
@@                Coverage Diff                @@
##           Version-v11.15.0   #24308   +/-   ##
=================================================
  Coverage             67.55%   67.55%           
=================================================
  Files                  1247     1247           
  Lines                 48934    48934           
  Branches              12775    12775           
=================================================
  Hits                  33055    33055           
  Misses                15879    15879

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danjm
Copy link
Copy Markdown
Contributor

danjm commented Apr 30, 2024

@hjetpoluru you can merge this when you are ready

@hjetpoluru hjetpoluru merged commit 07c10d5 into Version-v11.15.0 Apr 30, 2024
@hjetpoluru hjetpoluru deleted the enable_vault_decryption_test branch April 30, 2024 14:38
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
@metamaskbot metamaskbot added the release-11.15.0 Issue or pull request that will be included in release 11.15.0 label May 1, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 1, 2024

No release label on PR. Adding release label release-11.15.0 on PR, as PR was added to branch 11.15.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DDDDDanica DDDDDanica DDDDDanica approved these changes

+1 more reviewer

@danjm danjm danjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hjetpoluru hjetpoluru

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-11.15.0 Issue or pull request that will be included in release 11.15.0 team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hjetpoluru @metamaskbot @danjm @DDDDDanica