Conversation
…arket' Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| } | ||
| } else { | ||
| switch (gasEstimateType) { | ||
| case GasEstimateTypes.feeMarket: |
Member
There was a problem hiding this comment.
Not needed in this PR, but this is a fundamental public selector with no unit tests, so worth creating a ticket to add some and maybe even refactor the selector for readability at the same time.
matthewwalsh0
approved these changes
Apr 29, 2024
cryptotavares
approved these changes
Apr 29, 2024
Collaborator
Builds ready [510fae4]
Page Load Metrics (193 ± 268 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See Issue #24263 for investigation details
This will be a hotfix targeting v11.14.3
Related issues
Fixes: #24263
Manual testing steps
One way to repro is by adding the Scroll Sepholia Testnet (see: https://docs.scroll.io/en/user-guide/setup/), then using our test dapp > Send Eth > Send
For other repro methods, please refer to the related issue ticket
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist