Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
1277bd2 to
c5e0978
Compare
0f0a7f9 to
85398c5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24281 +/- ##
===========================================
- Coverage 65.79% 65.76% -0.02%
===========================================
Files 1364 1366 +2
Lines 54315 54385 +70
Branches 14126 14139 +13
===========================================
+ Hits 35732 35766 +34
- Misses 18583 18619 +36 ☔ View full report in Codecov by Sentry. |
Builds ready [85398c5]
Page Load Metrics (581 ± 501 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
85398c5 to
423ff7e
Compare
28d25b5 to
5237b5b
Compare
5237b5b to
d14ab2e
Compare
Hey @bergeron , It seems there's an issue with the process you're following. The modal in question is designed to show up exclusively during the onboarding/upgrade process, and it will only do so after a fresh installation of the app. if you're doing the fresh app using develop branch, you'll not see the modal. To replicate the issue, there are two methods. The first method applies to users who have the auto-detection feature turned off by default:
default-off.movThe second method is for users who had auto-detection enabled by default upon installing the app:
default-on.movLet me know if you need any further information or clarification. |
d14ab2e to
73b61f5
Compare
Builds ready [73b61f5]
Page Load Metrics (1353 ± 684 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
cca53f3 to
f9986a0
Compare
|
I ve tested the upgrade scenario and the fresh import, the modal was displayed correctly, thnx 🙏 |
ui/components/app/auto-detect-token/auto-detect-token-modal.tsx
Outdated
Show resolved
Hide resolved
83ba180 to
0f1081c
Compare
ui/components/app/auto-detect-token/auto-detect-token-modal.tsx
Outdated
Show resolved
Hide resolved
c85becb to
9814ae8
Compare
9814ae8 to
283fd03
Compare
Builds ready [283fd03]
Page Load Metrics (66 ± 8 ms)
|


Description
Add in recommended auto token enablement button in new Extension app update, once we enable auto token detection by default for new users, for existing users, we need to get them to turn on auto token detection as well.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
No Modal was displayed
After
Existing users with toggle off
Screen.Recording.2024-05-02.at.16.25.31.mov
Users with toggle on and want to disable it ( the modal should be displayed once )
Screen.Recording.2024-05-02.at.16.36.09.mov
Pre-merge author checklist
Pre-merge reviewer checklist