Skip to content

fix: duplicate fee display for l2 networks#24264

Merged
jpuri merged 4 commits intodevelopfrom
l2_layer_display_fix
May 1, 2024
Merged

fix: duplicate fee display for l2 networks#24264
jpuri merged 4 commits intodevelopfrom
l2_layer_display_fix

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented Apr 26, 2024

Description

Fix duplicate display of l1, l2 fees for l2 networks.

Related issues

Fixes: #23291

Manual testing steps

  1. Switch to optimism
  2. Submit legacy transaction in test dapp
  3. Check transaction screen

Screenshots/Recordings

Screenshot 2024-04-26 at 9 39 22 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri requested review from a team as code owners April 26, 2024 16:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 26, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 26, 2024
@sleepytanya
Copy link
Copy Markdown
Contributor

sleepytanya commented Apr 27, 2024

@jpuri Looks perfect!
With Simulations toggle ON:

Screenshot 2024-04-26 at 19 49 56

With Simulations toggle OFF:

Screenshot 2024-04-26 at 19 59 00

@CodyD42010
Copy link
Copy Markdown

CodyD42010 commented Apr 27, 2024

Uploading Screenshot_2024-04-07-01-12-43.png…

@seaona
Copy link
Copy Markdown
Member

seaona commented Apr 29, 2024

🟢 Looks good from my side too @jpuri gas L1/L2 section is not duplicated anymore and only appears in the Details section

@jpuri jpuri merged commit 9c83db2 into develop May 1, 2024
@jpuri jpuri deleted the l2_layer_display_fix branch May 1, 2024 08:16
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 1, 2024

Builds ready [db06164]
Page Load Metrics (704 ± 542 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint57156772211
domContentLoaded9281142
load4529097041128542
domInteractive8281142
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -902 Bytes (-0.01%)
  • common: 0 Bytes (0.00%)

@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@sleepytanya sleepytanya sleepytanya approved these changes

+1 more reviewer

@digiwand digiwand digiwand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-confirmations-secure-ux-PR PRs from the confirmations team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Gas - Duplicated fee section for Legacy transactions in L2

8 participants

@jpuri @sleepytanya @CodyD42010 @seaona @metamaskbot @matthewwalsh0 @digiwand @gauthierpetetin