Skip to content

chore: add infra for e2e for confirmations redesign#24240

Merged
pnarayanaswamy merged 1 commit intodevelopfrom
e2e-infra-setup
Apr 29, 2024
Merged

chore: add infra for e2e for confirmations redesign#24240
pnarayanaswamy merged 1 commit intodevelopfrom
e2e-infra-setup

Conversation

@pnarayanaswamy
Copy link
Copy Markdown
Contributor

@pnarayanaswamy pnarayanaswamy commented Apr 25, 2024 •
edited by digiwand
Loading

Description

Adding the e2e infra for confirmation redesign. Created two new jobs for chrome and FF following the pattern of multichain

Open in GitHub Codespaces

Related issues

Fixes: #23975

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 25, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pnarayanaswamy pnarayanaswamy added the team-confirmations-secure-ux-deprecated DEPRECATED: please use "team-confirmations" instead label Apr 25, 2024
@pnarayanaswamy pnarayanaswamy marked this pull request as ready for review April 25, 2024 13:27
@pnarayanaswamy pnarayanaswamy requested review from a team, brad-decker and kumavis as code owners April 25, 2024 13:27
@pnarayanaswamy pnarayanaswamy changed the title chore: add infra for e2e for confirmations redesgin chore: add infra for e2e for confirmations redesign Apr 25, 2024
jpuri
jpuri approved these changes Apr 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 great work

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 25, 2024

Builds ready [cb4a40d]
Page Load Metrics (1045 ± 572 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint611551052713
domContentLoaded106825147
load49267410451191572
domInteractive106725147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.46%. Comparing base (d8d9bc6) to head (cb4a40d).
Report is 3 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #24240   +/-   ##
========================================
  Coverage    67.46%   67.46%           
========================================
  Files         1263     1263           
  Lines        49327    49327           
  Branches     12854    12854           
========================================
  Hits         33278    33278           
  Misses       16049    16049

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

digiwand
digiwand reviewed Apr 26, 2024
View reviewed changes
.circleci/config.yml
fi
no_output_timeout: 5m
environment:
ENABLE_CONFIRMATION_REDESIGN: 1
Copy link
Copy Markdown
Contributor

@digiwand digiwand Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment: we use true to set the value, though this should yield the same result

same comment for line 1346

digiwand
digiwand approved these changes Apr 26, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@digiwand digiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

we can add

Fixes: #23975

to the description to automatically link the PR with the related issue

@pnarayanaswamy pnarayanaswamy merged commit 74678b0 into develop Apr 29, 2024
@pnarayanaswamy pnarayanaswamy deleted the e2e-infra-setup branch April 29, 2024 12:30
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@seaona seaona seaona approved these changes

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

@brad-decker brad-decker Awaiting requested review from brad-decker

+2 more reviewers

@danjm danjm danjm approved these changes

@digiwand digiwand digiwand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-confirmations-secure-ux-deprecated DEPRECATED: please use "team-confirmations" instead

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[e2e] Signature redesign - Create test for ENV variable and settings toggle

8 participants

@pnarayanaswamy @metamaskbot @jpuri @danjm @pedronfigueiredo @digiwand @seaona @gauthierpetetin