test: Reorganize e2e tests repo part2 by chloeYue · Pull Request #24238 · MetaMask/metamask-extension

chloeYue · 2024-04-25T09:54:39Z

Description

Following #23398, This PR is the second part to reorganize the test/e2e repository to create a structure that is both well-organized and easy to navigate.

Related issues

Fixes: #23296

Manual testing steps

Check if the organization is logical.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-04-25T09:54:54Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-04-26T16:02:28Z

Builds ready [4a51a26]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1150 ± 725 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	237	109	54	26
		domContentLoaded	9	89	22	21	10
		load	55	4183	1150	1510	725
		domInteractive	9	89	22	21	10

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-04-26T20:04:03Z

Builds ready [eff8a1f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (624 ± 545 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	57	145	81	21	10
		domContentLoaded	8	57	15	13	6
		load	45	3431	624	1135	545
		domInteractive	8	57	15	13	6

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2024-04-26T20:04:13Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.24%. Comparing base (bbb372f) to head (eff8a1f).

❗ Current head eff8a1f differs from pull request most recent head 3ab6fe1. Consider uploading reports for the commit 3ab6fe1 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #24238      +/-   ##
===========================================
- Coverage    67.28%   67.24%   -0.04%     
===========================================
  Files         1275     1271       -4     
  Lines        49707    49623      -84     
  Branches     12916    12908       -8     
===========================================
- Hits         33442    33367      -75     
+ Misses       16265    16256       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/manual-scenarios/1. onboarding/create a wallet.csv

DDDDDanica · 2024-04-29T09:45:02Z

LGTM ! Thanks for the work !

…2e-2

metamaskbot · 2024-04-29T16:13:27Z

Builds ready [3ab6fe1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1541 ± 781 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	69	168	111	28	13
		domContentLoaded	11	51	20	11	5
		load	60	3696	1541	1626	781
		domInteractive	11	51	20	11	5

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-06-04T20:06:41Z

Missing release label release-11.16.6 on PR. Adding release label release-11.16.6 on PR and removing other release labels(release-11.17.0), as PR was cherry-picked in branch 11.16.6.

chloeYue added team-extension-platform Extension Platform team e2e-test End to end test for the MetaMask extension labels Apr 25, 2024

chloeYue self-assigned this Apr 25, 2024

chloeYue requested a review from a team as a code owner April 25, 2024 09:54

chloeYue marked this pull request as draft April 25, 2024 09:54

chloeYue changed the title ~~Reorganiz e2e tests part2~~ test: Reorganize e2e tests part2 Apr 25, 2024

chloeYue added 7 commits April 26, 2024 15:45

reorganiz e2e tests part2

51176f3

resolve path issue

7c3fec6

ganache path

67f3a7d

fix lint

94eb8fb

phishing path

72109e3

lint

ae466a2

import path

83f2c54

chloeYue force-pushed the chloe-reorganize-e2e-2 branch from 8fd1b58 to 83f2c54 Compare April 26, 2024 14:23

chloeYue and others added 3 commits April 26, 2024 16:24

test run only on chrome

9cf28d3

fix

4a51a26

Merge branch 'develop' into chloe-reorganize-e2e-2

eff8a1f

chloeYue marked this pull request as ready for review April 29, 2024 07:58

chloeYue changed the title ~~test: Reorganize e2e tests part2~~ test: Reorganize e2e tests repo part2 Apr 29, 2024

pedronfigueiredo reviewed Apr 29, 2024

View reviewed changes

test/manual-scenarios/1. onboarding/create a wallet.csv Show resolved Hide resolved

DDDDDanica previously approved these changes Apr 29, 2024

View reviewed changes

remove confusing numbering

4b7773a

chloeYue dismissed DDDDDanica’s stale review via 4b7773a April 29, 2024 15:07

Merge remote-tracking branch 'origin/develop' into chloe-reorganize-e…

3ab6fe1

…2e-2

chloeYue mentioned this pull request Apr 29, 2024

WIP: feat(000): sort e2e tests and related test folder #23037

Closed

13 tasks

chloeYue requested review from DDDDDanica and pedronfigueiredo April 29, 2024 16:22

pedronfigueiredo approved these changes Apr 29, 2024

View reviewed changes

DDDDDanica approved these changes Apr 29, 2024

View reviewed changes

DDDDDanica merged commit 4caa85f into develop Apr 29, 2024

DDDDDanica deleted the chloe-reorganize-e2e-2 branch April 29, 2024 16:26

github-actions bot locked and limited conversation to collaborators Apr 29, 2024

metamaskbot added the release-11.17.0 label Apr 29, 2024

metamaskbot added release-11.16.6 Issue or pull request that will be included in release 11.16.6 and removed release-11.17.0 labels Jun 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Reorganize e2e tests repo part2#24238

test: Reorganize e2e tests repo part2#24238
DDDDDanica merged 12 commits intodevelopfrom
chloe-reorganize-e2e-2

chloeYue commented Apr 25, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Apr 25, 2024

Uh oh!

metamaskbot commented Apr 26, 2024

Uh oh!

metamaskbot commented Apr 26, 2024

Uh oh!

codecov bot commented Apr 26, 2024 •

edited

Loading

Uh oh!

Uh oh!

DDDDDanica commented Apr 29, 2024

Uh oh!

metamaskbot commented Apr 29, 2024

Uh oh!

metamaskbot commented Jun 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

chloeYue commented Apr 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Apr 25, 2024

Uh oh!

metamaskbot commented Apr 26, 2024

Uh oh!

metamaskbot commented Apr 26, 2024

Uh oh!

codecov bot commented Apr 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

DDDDDanica commented Apr 29, 2024

Uh oh!

metamaskbot commented Apr 29, 2024

Uh oh!

metamaskbot commented Jun 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chloeYue commented Apr 25, 2024 •

edited

Loading

codecov bot commented Apr 26, 2024 •

edited

Loading