Skip to content

fix(deps): Bump @metamask/obs-store@^8.1.0->^9.0.0#24233

Merged
legobeat merged 3 commits intoMetaMask:developfrom
legobeat:deps-obs-store-9
May 14, 2024
Merged

fix(deps): Bump @metamask/obs-store@^8.1.0->^9.0.0#24233
legobeat merged 3 commits intoMetaMask:developfrom
legobeat:deps-obs-store-9

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Apr 24, 2024 •
edited
Loading

Description

Bump @metamask/obs-store from ^8.1.0 to ^9.0.0.

The main change is moving from native runtime streams with streamsv2 libraries, to readable-stream@^3.6.2 implementation.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 24, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team labels Apr 24, 2024
@legobeat legobeat changed the title deps: Bump @metamask/obs-store@^8.1.0->^9.0.0 fix(deps): Bump @metamask/obs-store@^8.1.0->^9.0.0 Apr 24, 2024
@legobeat legobeat force-pushed the deps-obs-store-9 branch 3 times, most recently from 8f58826 to 8a5c13e Compare April 25, 2024 17:32
@legobeat

This comment was marked as resolved.

Sign in to view
@legobeat legobeat force-pushed the deps-obs-store-9 branch 14 times, most recently from 763e818 to de08b53 Compare May 7, 2024 09:53
@codecov
Copy link
Copy Markdown

codecov bot commented May 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.48%. Comparing base (d27a233) to head (8fb0423).
Report is 55 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #24233      +/-   ##
===========================================
+ Coverage    67.37%   67.48%   +0.11%     
===========================================
  Files         1278     1288      +10     
  Lines        49881    50153     +272     
  Branches     12944    13023      +79     
===========================================
+ Hits         33605    33841     +236     
- Misses       16276    16312      +36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat legobeat force-pushed the deps-obs-store-9 branch 4 times, most recently from ef5fe28 to ad66518 Compare May 7, 2024 12:33
@socket-security
Copy link
Copy Markdown

socket-security bot commented May 7, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/obs-store@9.0.0 None 0 30.8 kB lgbot

View full report↗︎

@socket-security
Copy link
Copy Markdown

socket-security bot commented May 7, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/obs-store@9.0.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@legobeat legobeat force-pushed the deps-obs-store-9 branch from ad66518 to 958d8a6 Compare May 7, 2024 12:38
@legobeat legobeat force-pushed the deps-obs-store-9 branch 24 times, most recently from 4de4b74 to 4dcfdb1 Compare May 9, 2024 07:18
@legobeat
Copy link
Copy Markdown
Contributor Author

legobeat commented May 9, 2024 

@SocketSecurity ignore npm/@metamask/obs-store@9.0.0

new author ok (says i)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kumavis kumavis kumavis approved these changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@FrederikBolding FrederikBolding Awaiting requested review from FrederikBolding

@mcmire mcmire Awaiting requested review from mcmire

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

@jiexi jiexi Awaiting requested review from jiexi

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-application-security Application security team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@legobeat @kumavis @pedronfigueiredo @benjisclowder