Version v11.15.0 remove unecessary pollings when mm closed#24219
Merged
danjm merged 2 commits intoVersion-v11.15.0from Apr 30, 2024
Merged
Conversation
Once nftDetection is enabled by the user, the nftDetection controller will start polling data in the background every 3 min even if the user closes the metamask popup or the tab. We want to stop unnecessary polling when MM is closed in an attempt to reduce traffic. [](https://codespaces.new/MetaMask/metamask-extension/pull/24026?quickstart=1) Related to: MetaMask/core#4178 1. Go to this page... 2. 3. <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [f121235]
Page Load Metrics (945 ± 573 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## Version-v11.15.0 #24219 +/- ##
====================================================
- Coverage 67.55% 67.53% -0.02%
====================================================
Files 1247 1247
Lines 48934 48949 +15
Branches 12775 12789 +14
====================================================
+ Hits 33055 33057 +2
- Misses 15879 15892 +13 ☔ View full report in Codecov by Sentry. |
danjm
reviewed
Apr 25, 2024
| + // Do not throw error here, supporting Metadata interface is optional even though majority of ERC721 nfts do support it. | ||
| + // This change is made because of instances of NFTs that are ERC404( mixed ERC20 / ERC721 implementation). | ||
| + // As of today, ERC404 is unofficial but some people use it, the contract does not support Metadata interface, but it has the tokenURI() fct. | ||
| + console.error('Contract does not support ERC721 metadata interface.'); |
Contributor
There was a problem hiding this comment.
@sahar-fehri I noticed this was not included in the original PR. Can you explain why it was needed in the cherry-pick?
Contributor
There was a problem hiding this comment.
The patch file was created in a previous PR that was already on develop but was not on the release branch yet. We decided to just include both parts of the patch in the release
Collaborator
|
No release label on PR. Adding release label release-11.15.0 on PR, as PR was added to branch 11.15.0 when release was cut. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picks #24162
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist