fix: hide installing Snaps from list#24215
Merged
FrederikBolding merged 1 commit intodevelopfrom Apr 29, 2024
Merged
Conversation
david0xd
approved these changes
Apr 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24215 +/- ##
===========================================
+ Coverage 67.49% 67.51% +0.02%
===========================================
Files 1260 1260
Lines 49271 49275 +4
Branches 12838 12846 +8
===========================================
+ Hits 33255 33267 +12
+ Misses 16016 16008 -8 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [120cf00]
Page Load Metrics (1606 ± 677 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
plasmacorral
approved these changes
Apr 25, 2024
Contributor
plasmacorral
left a comment
There was a problem hiding this comment.
This resolves the issue reported. Confirmed on Mac Sonoma 14.3.1 in both Firefox 124.0.2 and Chrome 117.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hides installing Snaps from the Snaps menu until they have finished installation to prevent a bad state where users could modify Snaps before they were fully installed.
Related issues
Fixes: MetaMask/snaps#2354