fix: token list cleared on network switch#24212
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
83d6cb1 to
107e8f0
Compare
… brian/tokenlist-polling-network-switch
7 tasks
sahar-fehri
approved these changes
Apr 24, 2024
salimtb
approved these changes
Apr 24, 2024
…etaMask/metamask-extension into brian/tokenlist-polling-network-switch
Collaborator
Builds ready [61c6680]
Page Load Metrics (1141 ± 630 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
|
Missing release label release-11.15.0 on PR. Adding release label release-11.15.0 on PR and removing other release labels(release-11.16.0), as PR was cherry-picked in branch 11.15.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem: When switching networks, the token list is cleared. Preventing token import via search or autodetect.
Diagnosis:
TokenListController.preventPollingOnNetworkRestartwas true, which intentionally clears the token list on network switch. Prior to #23919, this setting would be set false when enabling token autodetection. But this code path no longer triggers.Solution: Set the initial value of
preventPollingOnNetworkRestartbased on whether we need token lists.Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist