Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
pedronfigueiredo
previously approved these changes
Apr 24, 2024
pedronfigueiredo
previously approved these changes
Apr 24, 2024
…amask-extension into confirm_page_responsive_fix
pedronfigueiredo
approved these changes
Apr 26, 2024
digiwand
approved these changes
Apr 26, 2024
Contributor
digiwand
left a comment
There was a problem hiding this comment.
Lgtm!
screenshot of popup.html expanded:
we could consider adding padding top and bottom to this view later, possibly after we address the duplicate header issue
Collaborator
Builds ready [84415f3]
Page Load Metrics (1134 ± 634 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24211 +/- ##
========================================
Coverage 67.46% 67.46%
========================================
Files 1263 1263
Lines 49327 49327
Branches 12854 12854
========================================
Hits 33278 33278
Misses 16049 16049 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix confirm page layout in extended view.
Related issues
Fixes: #24055
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist