Skip to content

chore(deps): Bump base-controller to ^5.0.1#24209

Merged
Gudahtt merged 40 commits intodevelopfrom
bump-base-controller
Jun 12, 2024
Merged

chore(deps): Bump base-controller to ^5.0.1#24209
Gudahtt merged 40 commits intodevelopfrom
bump-base-controller

Conversation

@mcmire
Copy link
Copy Markdown
Contributor

@mcmire mcmire commented Apr 23, 2024

Description

This version of @metamask/base-controller does not introduce any functional changes, but there are a few developer experience improvements:

  • The controller messenger is now more type-safe, in that a messenger with an empty action/event allowlist guarantees that no actions/events are allowed to be called/emitted, and conversely, that a non-empty allowlist only allows the given actions/events
  • The "selector" version of subscribe (three arguments instead of two) is now fixed so that the arguments to the selector function are correctly typed.
  • It is now impossible to mutate state directly; state must only be mutated inside of a controller using the update method. This ensures that state updates are always controlled and expected.

View changelog: https://github.com/MetaMask/core/blob/%40metamask/base-controller%405.0.1/packages/base-controller/CHANGELOG.md

Open in GitHub Codespaces

Related issues

Progresses #24140.

Manual testing steps

(None needed as there should be no functional changes.)

Screenshots/Recordings

(None)

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

This version of `@metamask/base-controller` does not introduce any
functional changes, but there are a few developer experience
improvements:

- The controller messenger is now more type-safe, in that a messenger
  with an empty action/event allowlist guarantees that no actions/events
  are allowed to be called/emitted, and conversely, that a non-empty
  allowlist only allows the given actions/events
- The "selector" version of `subscribe` (three arguments instead of
  two) is now fixed so that the arguments to the selector function are
  correctly typed.
- It is now impossible to mutate state directly; state must only be
  mutated inside of a controller using the `update` method. This ensures
  that state updates are always controlled and expected.
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mcmire
Copy link
Copy Markdown
Contributor Author

mcmire commented Apr 24, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

Policies updated

@mikesposito mikesposito marked this pull request as ready for review May 21, 2024 10:01
@mikesposito mikesposito requested review from a team as code owners May 21, 2024 10:01
@mikesposito
Copy link
Copy Markdown
Member

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

Policies updated

@mikesposito
Copy link
Copy Markdown
Member

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

Policies updated

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [cf9af21]
Page Load Metrics (587 ± 496 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7312989168
domContentLoaded10311352
load5028885871033496
domInteractive10311352
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -164.37 KiB (-4.65%)
  • ui: 0 Bytes (0.00%)
  • common: -76.82 KiB (-1.22%)

@mikesposito mikesposito requested a review from a team May 29, 2024 10:56
@mikesposito
Copy link
Copy Markdown
Member

@metamaskbot update-policies

Gudahtt
Gudahtt previously approved these changes Jun 11, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Policy update failed. You can review the logs or retry the policy update here

1 similar comment
@metamaskbot
Copy link
Copy Markdown
Collaborator

Policy update failed. You can review the logs or retry the policy update here

@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Jun 12, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

Policies updated

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [529f9a8]
Page Load Metrics (330 ± 319 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7512990157
domContentLoaded10201221
load432222330664319
domInteractive10201221
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -151.08 KiB (-4.40%)
  • ui: 0 Bytes (0.00%)
  • common: -64.32 KiB (-1.02%)

@Gudahtt Gudahtt requested a review from Prithpal-Sooriya June 12, 2024 18:13
@Gudahtt Gudahtt merged commit e407384 into develop Jun 12, 2024
@Gudahtt Gudahtt deleted the bump-base-controller branch June 12, 2024 18:18
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.1.0 Issue or pull request that will be included in release 12.1.0

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

10 participants