chore(deps): Bump base-controller to ^5.0.1#24209
Merged
Conversation
This version of `@metamask/base-controller` does not introduce any functional changes, but there are a few developer experience improvements: - The controller messenger is now more type-safe, in that a messenger with an empty action/event allowlist guarantees that no actions/events are allowed to be called/emitted, and conversely, that a non-empty allowlist only allows the given actions/events - The "selector" version of `subscribe` (three arguments instead of two) is now fixed so that the arguments to the selector function are correctly typed. - It is now impossible to mutate state directly; state must only be mutated inside of a controller using the `update` method. This ensures that state updates are always controlled and expected.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
24 tasks
Contributor
Author
|
@metamaskbot update-policies |
Collaborator
|
Policies updated |
Member
|
@metamaskbot update-policies |
Collaborator
|
Policies updated |
Member
|
@metamaskbot update-policies |
Collaborator
|
Policies updated |
Collaborator
Builds ready [cf9af21]
Page Load Metrics (587 ± 496 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Prithpal-Sooriya
previously approved these changes
Jun 7, 2024
48fa891
Member
|
@metamaskbot update-policies |
Gudahtt
previously approved these changes
Jun 11, 2024
Collaborator
|
Policy update failed. You can review the logs or retry the policy update here |
1 similar comment
Collaborator
|
Policy update failed. You can review the logs or retry the policy update here |
Member
|
@metamaskbot update-policies |
Collaborator
|
Policies updated |
Collaborator
Builds ready [529f9a8]
Page Load Metrics (330 ± 319 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Gudahtt
approved these changes
Jun 12, 2024
davidmurdoch
approved these changes
Jun 12, 2024
Prithpal-Sooriya
approved these changes
Jun 12, 2024
gantunesr
approved these changes
Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This version of
@metamask/base-controllerdoes not introduce any functional changes, but there are a few developer experience improvements:subscribe(three arguments instead of two) is now fixed so that the arguments to the selector function are correctly typed.updatemethod. This ensures that state updates are always controlled and expected.View changelog: https://github.com/MetaMask/core/blob/%40metamask/base-controller%405.0.1/packages/base-controller/CHANGELOG.md
Related issues
Progresses #24140.
Manual testing steps
(None needed as there should be no functional changes.)
Screenshots/Recordings
(None)
Pre-merge author checklist
Pre-merge reviewer checklist