fix: remove requirement for EIP-55 address when parsing SIWE message#24204
Merged
digiwand merged 1 commit intofix-siwe-parser-resolution-to-allow-schema-in-urlfrom Apr 23, 2024
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
|
lgtm! will merge into the base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base branch is #24138
Description
Upon testing the new
@spruceid/siwe-parserchanges, @digiwand noticed that message parsing would fail when using the MetaMask Test dApp. During this investigation, it was identified that the parsing failed due to the isEIP55Address check.This is due to the fact that an EIP-55 address is case sensitive, but MetaMask lowercases the wallet address before returning it to an
eth_accountscall. This means that when dApps attempt to request a SIWE message (using this lowecase address), the operation would fail to parse.This change removes that check, and provides the consistent experience we have already been giving prior to the
@spruceid/siwe-parserv2 upgrade.Related issues
Adds to #24138
Pre-merge author checklist
Pre-merge reviewer checklist