Skip to content

fix: Provider padding to address button in Receive modal#24200

Merged
darkwing merged 2 commits intodevelopfrom
receive-modal-padding
Apr 25, 2024
Merged

fix: Provider padding to address button in Receive modal#24200
darkwing merged 2 commits intodevelopfrom
receive-modal-padding

Conversation

@darkwing
Copy link
Copy Markdown
Contributor

@darkwing darkwing commented Apr 23, 2024 •
edited by github-actions bot
Loading

Description

The "Receive tokens" modal doesn't have padding around the AddressCopyButton and it looks bad. This PR adds padding in.

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

  1. On the wallet screen, click "Receive tokens"
  2. See padding around the AddressCopyButton

Screenshots/Recordings

Before

SCR-20240423-kyfy

After

SCR-20240423-kybe

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner April 23, 2024 17:13
@darkwing darkwing added team-core-extension-ux Core Extension UX team needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Apr 23, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 23, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 24, 2024

Builds ready [33368ae]
Page Load Metrics (580 ± 488 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint63158962612
domContentLoaded95920115
load5228325801016488
domInteractive95920115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 40 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@EtherWizard33 EtherWizard33 self-requested a review April 24, 2024 12:14
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.49%. Comparing base (6c465bc) to head (a39939b).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #24200   +/-   ##
========================================
  Coverage    67.49%   67.49%           
========================================
  Files         1264     1264           
  Lines        49362    49362           
  Branches     12863    12863           
========================================
  Hits         33313    33313           
  Misses       16049    16049

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 25, 2024

Builds ready [a39939b]
Page Load Metrics (501 ± 519 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint56160822612
domContentLoaded86318178
load4640045011082519
domInteractive86318178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 40 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@darkwing darkwing merged commit 8860a10 into develop Apr 25, 2024
@darkwing darkwing deleted the receive-modal-padding branch April 25, 2024 15:43
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@salimtb salimtb salimtb approved these changes

+1 more reviewer

@EtherWizard33 EtherWizard33 EtherWizard33 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@darkwing @metamaskbot @salimtb @EtherWizard33 @gauthierpetetin