feat: added e2e tests for connections page#24161
Conversation
darkwing
left a comment
There was a problem hiding this comment.
Added ideas for improvements.
|
nit: just an idea for improvement, maybe it could be nice to use AAA (adding three comments // Arrange // Act // Assert) to separate the part of the test which is setup from what we are actually testing and asserting. It could apply nicely to the second test in this PR. Certainly! The Arrange-Act-Assert (AAA) pattern is a clear and structured approach for writing unit tests, ensuring they are easy to read, write, and maintain. Here's a concise explanation: Why Use AAA?
How to Implement AAA:
Just a nit and maybe something we could consider, otherwise I can go ahead and approve as a second reviewer following David's comments. |
Builds ready [9f4979a]
Page Load Metrics (2043 ± 785 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24161 +/- ##
========================================
Coverage 67.45% 67.45%
========================================
Files 1258 1258
Lines 49236 49236
Branches 12819 12819
========================================
Hits 33212 33212
Misses 16024 16024 ☔ View full report in Codecov by Sentry. |
This PR is to add e2e test for connections page for the following features:
Related issues
Fixes: #24166
Manual testing steps
MULTICHAIN=1 yarn test:e2e:single --browser=chrome test/e2e/tests/connection-page.spec.js --leave-runningScreenshots/Recordings
NA it's a test
Pre-merge author checklist
Pre-merge reviewer checklist