fix: Remove snaps, add highlight to connection list#24099
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
darkwing
reviewed
Apr 18, 2024
| &:active { | ||
| background-color: var(--color-background-default-hover); | ||
| } | ||
| } No newline at end of file |
darkwing
reviewed
Apr 18, 2024
| @@ -0,0 +1,2 @@ | |||
| @import './connection-list-item'; | |||
| @import './permissions-page'; No newline at end of file | |||
salimtb
reviewed
Apr 19, 2024
| textAlign={TextAlign.Center} | ||
| padding={4} | ||
| > | ||
| {t('siteConnections')} |
Contributor
There was a problem hiding this comment.
locale should be removed from en.json file and all the translations file
salimtb
reviewed
Apr 19, 2024
| <Tabs tabsClassName="permissions-page__tabs"> | ||
| <Tab | ||
| data-testid="permissions-page-sites-tab" | ||
| name={t('sites')} |
Contributor
There was a problem hiding this comment.
locale should be removed from en.json file and all the translations file
salimtb
reviewed
Apr 19, 2024
| textAlign={TextAlign.Center} | ||
| padding={4} | ||
| > | ||
| {t('snapConnections')} |
Contributor
There was a problem hiding this comment.
same here , should locale should be removed
Contributor
|
@jonybur |
7 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24099 +/- ##
===========================================
- Coverage 67.46% 67.43% -0.03%
===========================================
Files 1259 1259
Lines 49268 49255 -13
Branches 12826 12817 -9
===========================================
- Hits 33238 33213 -25
- Misses 16030 16042 +12 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [8a9aa64]
Page Load Metrics (1123 ± 609 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
darkwing
approved these changes
Apr 22, 2024
NidhiKJha
approved these changes
Apr 23, 2024
Collaborator
Builds ready [47da602]
Page Load Metrics (725 ± 539 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On-hover behavior for Connected Site on All Permissions screen.
Sites listed on the All Permissions screen should have an on-hover bg color to indicate that they are clickable and will take users to a different screen.
Snaps are removed from Permissions page
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
highlight.mp4
Pre-merge author checklist
Pre-merge reviewer checklist