Skip to content

chore: add e2e tests for rejection of signatures#24077

Merged
pnarayanaswamy merged 4 commits intodevelopfrom
signature-reject
Apr 29, 2024
Merged

chore: add e2e tests for rejection of signatures#24077
pnarayanaswamy merged 4 commits intodevelopfrom
signature-reject

Conversation

@pnarayanaswamy
Copy link
Copy Markdown
Contributor

@pnarayanaswamy pnarayanaswamy commented Apr 17, 2024 •
edited
Loading

Description

Create e2e tests:

Navigation (signatures only)

  • I can navigate through multiple signatures
  • I can reject all signatures at once
  • I can reject/accept signatures one by one

Navigation (mix transaction + signatures)

  • I can navigate through multiple signatures and transactions
  • I can reject all signatures and transactions at once
  • I can reject/accept signatures and transactions one by one

Open in GitHub Codespaces

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 17, 2024 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 17, 2024
@pnarayanaswamy
Copy link
Copy Markdown
Contributor Author

pnarayanaswamy commented Apr 18, 2024

I have read the CLA Document and I hereby sign the CLA

@pnarayanaswamy pnarayanaswamy added the team-confirmations-secure-ux-deprecated DEPRECATED: please use "team-confirmations" instead label Apr 18, 2024
@pnarayanaswamy pnarayanaswamy marked this pull request as ready for review April 29, 2024 12:34
@pnarayanaswamy pnarayanaswamy requested a review from a team as a code owner April 29, 2024 12:34
jpuri
jpuri approved these changes Apr 29, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

seaona
seaona approved these changes Apr 29, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@seaona seaona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 29, 2024

Builds ready [7848c23]
Page Load Metrics (1436 ± 720 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint702831165426
domContentLoaded9195264120
load57363014361500720
domInteractive9195264120
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.28%. Comparing base (c5e95a4) to head (7848c23).
Report is 24 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #24077      +/-   ##
===========================================
- Coverage    67.47%   67.28%   -0.19%     
===========================================
  Files         1260     1275      +15     
  Lines        49271    49707     +436     
  Branches     12830    12916      +86     
===========================================
+ Hits         33241    33443     +202     
- Misses       16030    16264     +234

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnarayanaswamy pnarayanaswamy merged commit bbb372f into develop Apr 29, 2024
@pnarayanaswamy pnarayanaswamy deleted the signature-reject branch April 29, 2024 14:17
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

@seaona seaona seaona approved these changes

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-confirmations-secure-ux-deprecated DEPRECATED: please use "team-confirmations" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pnarayanaswamy @metamaskbot @jpuri @seaona @gauthierpetetin