fix: replace last usages of legacy gas fee polling with polling by networkClientId#24065
Merged
fix: replace last usages of legacy gas fee polling with polling by networkClientId#24065
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24065 +/- ##
===========================================
- Coverage 67.59% 67.59% -0.00%
===========================================
Files 1250 1250
Lines 48987 49005 +18
Branches 12792 12802 +10
===========================================
+ Hits 33110 33122 +12
- Misses 15877 15883 +6 ☔ View full report in Codecov by Sentry. |
BelfordZ
previously approved these changes
Apr 16, 2024
Contributor
BelfordZ
left a comment
There was a problem hiding this comment.
smell ya later, old polling!
Collaborator
Builds ready [a8d0d2f]
Page Load Metrics (1296 ± 645 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
jpuri
previously approved these changes
Apr 17, 2024
Contributor
jpuri
left a comment
There was a problem hiding this comment.
I reviewed all confirmation components related code and it looks good 👍
cc492cb
Collaborator
Builds ready [cc492cb]
Page Load Metrics (1327 ± 661 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
adonesky1
approved these changes
Apr 17, 2024
Contributor
|
Ok nevermind was a fluke. This appears to be working as expected! |
jpuri
approved these changes
Apr 17, 2024
Collaborator
Builds ready [c7accb4]
Page Load Metrics (2303 ± 547 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#23010 made initial changes to replace the GasFeeController's legacy gas fee polling in favor of polling via networkClientId. It was discovered that there are still lingering instances of the legacy gas fee polling which were causing double polling to occur since the legacy and networkClientId based polling run on separate loops. This PR fixes this by replacing those remaining legacy gas fee polling usages.
Related issues
Fixes: #23010
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist