Skip to content

feat: Update UI / content for the Smart Transactions Opt In modal, renaming#24053

Merged
dan437 merged 3 commits intodevelopfrom
stx-1.2
Apr 16, 2024
Merged

feat: Update UI / content for the Smart Transactions Opt In modal, renaming#24053
dan437 merged 3 commits intodevelopfrom
stx-1.2

Conversation

@dan437
Copy link
Copy Markdown
Contributor

@dan437 dan437 commented Apr 16, 2024

Description

This PR includes a few small updates:

  • Updates UI / content for the Smart Transactions Opt In modal
  • Renaming to Smart Transactions
  • Small refactoring

Related issues

Fixes:

Manual testing steps

  1. Install the extension
  2. See the updated Smart Transactions Opt In Modal

Screenshots/Recordings

Smart Transactions Opt In Modal:
image

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dan437 dan437 added team-swaps-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead release-11.15.0 Issue or pull request that will be included in release 11.15.0 labels Apr 16, 2024
@dan437 dan437 requested review from a team as code owners April 16, 2024 14:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dan437 dan437 merged commit 8c8f68f into develop Apr 16, 2024
@dan437 dan437 deleted the stx-1.2 branch April 16, 2024 14:48
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 16, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 16, 2024

Builds ready [ffd151f]
Page Load Metrics (1063 ± 636 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint712521325225
domContentLoaded107725189
load58320910631326636
domInteractive107725189
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 12 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot metamaskbot removed the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 25, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 25, 2024

More than one release label on PR. Keeping the lowest one (release-11.15.0) on PR and removing other release labels (release-11.16.0).

@dan437 dan437 added team-transactions Transactions team and removed team-swaps-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead labels May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@infiniteflower infiniteflower infiniteflower approved these changes

+1 more reviewer

@antonydenyer antonydenyer antonydenyer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.15.0 Issue or pull request that will be included in release 11.15.0 team-transactions Transactions team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dan437 @metamaskbot @antonydenyer @matthewwalsh0 @infiniteflower