feat: New onboarding text by jonybur · Pull Request #24050 · MetaMask/metamask-extension

jonybur · 2024-04-16T11:25:29Z

Description

Updates the "Help us improve MetaMask" copy during onboarding.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2336

Manual testing steps

Start onboarding
Check that the copy in the 'Help us improve MetaMask' screen matches the new copy.
Test the Privacy Policy link

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-04-16T11:25:43Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

… fix-2336

ui/helpers/constants/privacy-policy.ts

ui/pages/onboarding-flow/metametrics/metametrics.js

app/_locales/en/messages.json

…o fix-2336

mikesposito · 2024-05-09T14:58:47Z

ui/pages/onboarding-flow/metametrics/metametrics.js

+
+  return currentDate >= newPrivacyPolicyDate
+    ? renderOnboarding()
+    : renderLegacyOnboarding();


Do we plan to remove this after the 4th of June?

Date is to be set, but yes at some point we need to revert the PR cc @jonybur

Nit: perhaps we can add a // TODO: comment to remember about this

darkwing

Assuming jest gets fixed, this looks good!

ui/pages/onboarding-flow/metametrics/metametrics.test.js

mikesposito · 2024-05-10T10:46:52Z

Except for test-unit-jest-main (which should become green after the above-suggested changes), other failures seem unrelated to this PR

Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com>

mikesposito

A small nit left, but this looks good!

mikesposito · 2024-05-10T11:48:07Z

ui/pages/onboarding-flow/metametrics/metametrics.js

+    );
+  };
+
+  return currentDate >= newPrivacyPolicyDate


Nit: can we add a TODO so that we don't forget about the possibility of removing this and making it simple again in the future?

Suggested change

return currentDate >= newPrivacyPolicyDate

// TODO: The legacy onboarding can be completely removed after 2024-06-04

return currentDate >= newPrivacyPolicyDate

We will probably reuse this in the future, once the privacy policy gets updated once again

codecov · 2024-05-10T19:09:42Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.43%. Comparing base (d27a233) to head (941467f).
Report is 59 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #24050      +/-   ##
===========================================
+ Coverage    67.37%   67.43%   +0.06%     
===========================================
  Files         1278     1289      +11     
  Lines        49881    50249     +368     
  Branches     12944    13027      +83     
===========================================
+ Hits         33605    33883     +278     
- Misses       16276    16366      +90

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-05-10T19:29:37Z

Builds ready [a7cb32d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (452 ± 441 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	168	87	26	12
		domContentLoaded	9	51	16	12	6
		load	54	2765	452	918	441
		domInteractive	9	51	16	12	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.18 KiB (0.05%)
common: 1.51 KiB (0.02%)

metamaskbot · 2024-05-14T21:10:58Z

Builds ready [adcdba8]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1544 ± 787 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	73	202	117	44	21
		domContentLoaded	10	44	17	8	4
		load	59	3879	1544	1639	787
		domInteractive	10	44	17	8	4

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 2.81 KiB (0.04%)
common: 1.51 KiB (0.02%)

New onboarding text

19f6fd1

jonybur added team-core-extension-ux Core Extension UX team needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Apr 18, 2024

Jonathan Bursztyn added 2 commits May 5, 2024 01:15

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

595c1b7

… fix-2336

Update copy

2647179

jonybur marked this pull request as ready for review May 5, 2024 00:55

jonybur requested a review from a team as a code owner May 5, 2024 00:55

jonybur marked this pull request as draft May 5, 2024 01:08

Jonathan Bursztyn added 2 commits May 5, 2024 02:35

Add legacy messages

0ef21e9

Add legacy onboarding with feature flag

35ed6e3

jonybur marked this pull request as ready for review May 5, 2024 01:58

jonybur marked this pull request as draft May 5, 2024 02:03

jonybur marked this pull request as ready for review May 5, 2024 02:03

Fix lint

9d2a00d

salimtb reviewed May 6, 2024

View reviewed changes

ui/helpers/constants/privacy-policy.ts Show resolved Hide resolved

salimtb reviewed May 6, 2024

View reviewed changes

ui/pages/onboarding-flow/metametrics/metametrics.js Show resolved Hide resolved

Jonathan Bursztyn and others added 3 commits May 9, 2024 11:39

Add test

f84ce79

Add comment

847744c

Merge branch 'develop' into fix-2336

f45e521

jonybur requested a review from salimtb May 9, 2024 10:42

mikesposito reviewed May 9, 2024

View reviewed changes

app/_locales/en/messages.json Show resolved Hide resolved

Merge branch 'develop' into fix-2336

cacd33f

Gudahtt reviewed May 9, 2024

View reviewed changes

app/_locales/en/messages.json Outdated Show resolved Hide resolved

Jonathan Bursztyn added 3 commits May 9, 2024 15:20

Update naming convention

6f24b4f

Merge branch 'fix-2336' of github.com:MetaMask/metamask-extension int…

232ab55

…o fix-2336

Update all locales

467f0a3

mikesposito reviewed May 9, 2024

View reviewed changes

darkwing reviewed May 9, 2024

View reviewed changes

Fix legacy test

83fd0a5

Merge branch 'develop' into fix-2336

dee306c

mikesposito reviewed May 10, 2024

View reviewed changes

ui/pages/onboarding-flow/metametrics/metametrics.test.js Outdated Show resolved Hide resolved

ui/pages/onboarding-flow/metametrics/metametrics.test.js Outdated Show resolved Hide resolved

Jony Bursztyn and others added 2 commits May 10, 2024 12:37

Update ui/pages/onboarding-flow/metametrics/metametrics.test.js

4ab0d39

Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com>

Update ui/pages/onboarding-flow/metametrics/metametrics.test.js

a7cb32d

Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com>

jonybur requested review from Gudahtt, darkwing and mikesposito May 10, 2024 11:38

mikesposito previously approved these changes May 10, 2024

View reviewed changes

vthomas13 previously approved these changes May 10, 2024

View reviewed changes

Merge branch 'develop' into fix-2336

941467f

jonybur dismissed stale reviews from vthomas13 and mikesposito via 941467f May 14, 2024 14:40

Merge branch 'develop' into fix-2336

adcdba8

vthomas13 approved these changes May 15, 2024

View reviewed changes

jonybur requested a review from mikesposito May 16, 2024 08:04

mikesposito approved these changes May 16, 2024

View reviewed changes

jonybur merged commit 6be0bad into develop May 16, 2024

jonybur deleted the fix-2336 branch May 16, 2024 18:55

github-actions bot locked and limited conversation to collaborators May 16, 2024

metamaskbot added the release-11.18.0 label May 16, 2024

hesterbruikman added the area-privacy label May 17, 2024

gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024

	return currentDate >= newPrivacyPolicyDate
	// TODO: The legacy onboarding can be completely removed after 2024-06-04
	return currentDate >= newPrivacyPolicyDate

Conversation

jonybur commented Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Apr 16, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mikesposito May 9, 2024

Choose a reason for hiding this comment

Uh oh!

hesterbruikman May 10, 2024

Choose a reason for hiding this comment

Uh oh!

mikesposito May 10, 2024

Choose a reason for hiding this comment

Uh oh!

darkwing left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mikesposito commented May 10, 2024

Uh oh!

mikesposito left a comment

Choose a reason for hiding this comment

Uh oh!

mikesposito May 10, 2024

Choose a reason for hiding this comment

Uh oh!

jonybur May 10, 2024

Choose a reason for hiding this comment

Uh oh!

codecov bot commented May 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented May 10, 2024

Uh oh!

metamaskbot commented May 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

jonybur commented Apr 16, 2024 •

edited

Loading

codecov bot commented May 10, 2024 •

edited

Loading