Skip to content

feat: add filecoin logo svg#24039

Merged
salimtb merged 2 commits intodevelopfrom
update-filecoin-logo
Apr 16, 2024
Merged

feat: add filecoin logo svg#24039
salimtb merged 2 commits intodevelopfrom
update-filecoin-logo

Conversation

@salimtb
Copy link
Copy Markdown
Contributor

@salimtb salimtb commented Apr 15, 2024 •
edited by github-actions bot
Loading

Description

Add Filecoin svg logo

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to add network
  2. Add filecoin network
    3.filecoin network should have a logo
  3. filecoin token should have a logo

Screenshots/Recordings

Before

Screenshot 2024-04-16 at 00 22 03

After

Screenshot 2024-04-16 at 00 05 49

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb requested a review from a team as a code owner April 15, 2024 22:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Apr 15, 2024
@salimtb salimtb self-assigned this Apr 15, 2024
@salimtb salimtb requested review from bergeron and sahar-fehri April 15, 2024 22:23
@salimtb salimtb force-pushed the update-filecoin-logo branch from efe4861 to d20d54e Compare April 15, 2024 22:32
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.60%. Comparing base (f23f095) to head (066e82f).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #24039   +/-   ##
========================================
  Coverage    67.60%   67.60%           
========================================
  Files         1245     1245           
  Lines        48833    48834    +1     
  Branches     12759    12759           
========================================
+ Hits         33009    33010    +1     
  Misses       15824    15824

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 15, 2024

Builds ready [d20d54e]
Page Load Metrics (1528 ± 698 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint793821438239
domContentLoaded1792302210
load59350415281454698
domInteractive1792302210
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 151 Bytes (0.00%)

@legobeat legobeat requested a review from a team April 16, 2024 06:45
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 16, 2024

Builds ready [066e82f]
Page Load Metrics (1263 ± 772 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint853171536431
domContentLoaded127633189
load70424212631608772
domInteractive117633189
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 151 Bytes (0.00%)

@salimtb salimtb merged commit 3798950 into develop Apr 16, 2024
@salimtb salimtb deleted the update-filecoin-logo branch April 16, 2024 12:57
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NidhiKJha NidhiKJha NidhiKJha approved these changes

@bergeron bergeron Awaiting requested review from bergeron

@sahar-fehri sahar-fehri Awaiting requested review from sahar-fehri

+1 more reviewer

@legobeat legobeat legobeat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@salimtb salimtb

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.16.0 Issue or pull request that will be included in release 11.16.0 team-assets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@salimtb @metamaskbot @NidhiKJha @legobeat