feat: improve blockaid error/warning copy#24037
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jpuri
reviewed
Apr 16, 2024
Contributor
There was a problem hiding this comment.
I think we should keep above comment, the issue I think is when i18n message keys should not be used like above. That makes it hard for i18n tool to discover un-used keys etc.
Contributor
Author
There was a problem hiding this comment.
okay sure. I wasn't sure why the comment was there.
jpuri
previously approved these changes
Apr 16, 2024
Contributor
jpuri
left a comment
There was a problem hiding this comment.
LGTM except a small comment added.
blackdevelopa
previously approved these changes
Apr 16, 2024
1bb685c to
c06b5d7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24037 +/- ##
========================================
Coverage 67.58% 67.58%
========================================
Files 1247 1247
Lines 48934 48934
Branches 12774 12774
========================================
Hits 33069 33069
Misses 15865 15865 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [32ff830]
Page Load Metrics (1515 ± 684 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
jpuri
approved these changes
Apr 16, 2024
blackdevelopa
approved these changes
Apr 16, 2024
Collaborator
Builds ready [36e6a93]
Page Load Metrics (2039 ± 618 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We should update content for:
when ppom returns warning as response
Related issues
Fixes: #1758
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist