fix: add patch for fetching tokenURI for ERC404#24029
Merged
sahar-fehri merged 3 commits intodevelopfrom Apr 19, 2024
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
|
@sahar-fehri be careful, your patch will edit the yarn.lock , this should be included on the change files list and submitted for a review |
Collaborator
Builds ready [154a7cb]
Page Load Metrics (1226 ± 556 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [885be71]
Page Load Metrics (2053 ± 712 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24029 +/- ##
========================================
Coverage 67.60% 67.60%
========================================
Files 1251 1251
Lines 49000 49000
Branches 12793 12793
========================================
Hits 33125 33125
Misses 15875 15875 ☔ View full report in Codecov by Sentry. |
salimtb
approved these changes
Apr 18, 2024
darkwing
approved these changes
Apr 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have been contacted about an NFT on linea mainnet that was not showing properly on MM.
There is this core PR that has been merged to fix fetch behavior for ERC404: MetaMask/core#4136
This PR adds a patch for the core fix.
Related issues
Fixes:
Related: MetaMask/core#4136
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2024-04-15.at.14.43.34.mov
After
Screen.Recording.2024-04-15.at.14.37.08.mov
Pre-merge author checklist
Pre-merge reviewer checklist