Skip to content

fix: updated connections page for connected data#24022

Merged
NidhiKJha merged 1 commit intodevelopfrom
connection-page-fix
Apr 16, 2024
Merged

fix: updated connections page for connected data#24022
NidhiKJha merged 1 commit intodevelopfrom
connection-page-fix

Conversation

@NidhiKJha
Copy link
Copy Markdown
Member

@NidhiKJha NidhiKJha commented Apr 15, 2024

In the previous logic, we were using activeTabOrigin to get the subject MetaData to get the connected Dapp MetaData but it seems like there is another bug because of which metaData is not being fetched correctly. As a result, we are not able to get the connected Dapp Logo and connected status properly. In this PR, we are relying on getPermittedAccountsForCurrentTab to get the connected status and if the connected dapp metaData is not defined, we will rely on global icon rather than connected dapp icon

Related issues

Fixes: #23792

Manual testing steps

  1. Run extension with Multichain Flag and connect it to dapp
  2. If the dapp shows connected status, then the connection page should return the connected accounts
  3. Test it with multiple Dapps

Screenshots/Recordings

Before

Refer to the issue

After

Screen.Recording.2024-04-15.at.2.52.08.PM.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested a review from a team as a code owner April 15, 2024 06:29
@NidhiKJha NidhiKJha added DO-NOT-MERGE Pull requests that should not be merged team-core-extension-ux Core Extension UX team needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Apr 15, 2024
@NidhiKJha NidhiKJha marked this pull request as draft April 15, 2024 06:30
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 15, 2024
@NidhiKJha NidhiKJha force-pushed the connection-page-fix branch from ec90354 to d42286c Compare April 15, 2024 09:08
@NidhiKJha NidhiKJha marked this pull request as ready for review April 15, 2024 09:24
@NidhiKJha NidhiKJha removed the DO-NOT-MERGE Pull requests that should not be merged label Apr 15, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.56%. Comparing base (07de882) to head (d42286c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24022   +/-   ##
========================================
  Coverage    67.56%   67.56%           
========================================
  Files         1246     1246           
  Lines        48892    48893    +1     
  Branches     12747    12747           
========================================
+ Hits         33031    33032    +1     
  Misses       15861    15861           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NidhiKJha NidhiKJha changed the title updated connections page for connected data fix: updated connections page for connected data Apr 15, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [d42286c]
Page Load Metrics (687 ± 500 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint783311225527
domContentLoaded165828126
load6527966871040500
domInteractive165828126
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 165 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@NidhiKJha NidhiKJha merged commit 8f3270f into develop Apr 16, 2024
@NidhiKJha NidhiKJha deleted the connection-page-fix branch April 16, 2024 08:42
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.16.0 Issue or pull request that will be included in release 11.16.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Multichain - discrepancy between the information 'Connected sites' in the three-dot menu and when clicking on the favicon.

4 participants