fix: updated connections page for connected data#24022
Merged
Conversation
ec90354 to
d42286c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24022 +/- ##
========================================
Coverage 67.56% 67.56%
========================================
Files 1246 1246
Lines 48892 48893 +1
Branches 12747 12747
========================================
+ Hits 33031 33032 +1
Misses 15861 15861 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [d42286c]
Page Load Metrics (687 ± 500 ms)
Bundle size diffs
|
darkwing
approved these changes
Apr 15, 2024
sahar-fehri
approved these changes
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the previous logic, we were using activeTabOrigin to get the subject MetaData to get the connected Dapp MetaData but it seems like there is another bug because of which metaData is not being fetched correctly. As a result, we are not able to get the connected Dapp Logo and connected status properly. In this PR, we are relying on getPermittedAccountsForCurrentTab to get the connected status and if the connected dapp metaData is not defined, we will rely on global icon rather than connected dapp icon
Related issues
Fixes: #23792
Manual testing steps
Screenshots/Recordings
Before
Refer to the issue
After
Screen.Recording.2024-04-15.at.2.52.08.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist