fix: checkmark icon missing after token import#24005
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
salimtb
approved these changes
Apr 12, 2024
Collaborator
Builds ready [53a3e10]
Page Load Metrics (1510 ± 626 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24005 +/- ##
========================================
Coverage 67.56% 67.56%
========================================
Files 1246 1246
Lines 48888 48888
Branches 12746 12746
========================================
Hits 33031 33031
Misses 15857 15857 ☔ View full report in Codecov by Sentry. |
sahar-fehri
approved these changes
Apr 12, 2024
NidhiKJha
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After importing an erc20 token, the popup message was not rendering the checkmark icon.
The icon is from font-awesome, and their CSS works fine. But when we add
@include design-system.H3, it overrode the font-family, breaking the icon.Fixed by setting font size directly rather than bringing the whole H3.
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist