build: remove brfs from build processes#24000
Merged
davidmurdoch merged 1 commit intodevelopfrom Apr 15, 2024
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/array-from@2.1.1, npm/brfs@2.0.2, npm/buffer-equal@0.0.1, npm/dash-ast@2.0.1, npm/es6-map@0.1.5, npm/es6-set@0.1.6, npm/estree-is-function@1.0.0, npm/merge-source-map@1.0.4, npm/quote-stream@1.0.2, npm/scope-analyzer@2.1.2, npm/shallow-copy@0.0.1, npm/static-eval@2.1.1, npm/static-module@3.0.4 |
4e96037 to
281ad41
Compare
e7a251d to
b597020
Compare
b597020 to
e0fb026
Compare
Collaborator
Builds ready [e0fb026]
Page Load Metrics (1244 ± 571 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24000 +/- ##
========================================
Coverage 67.54% 67.54%
========================================
Files 1245 1245
Lines 48866 48866
Branches 12744 12744
========================================
Hits 33005 33005
Misses 15861 15861 ☔ View full report in Codecov by Sentry. |
brad-decker
approved these changes
Apr 15, 2024
vthomas13
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
brfspackage was used to transform calls tofs.readFile*into inlined files as strings during build/compilation. We no longer make use offs.readFile*in our code, so the dependency is no longer required. While it doesn't cause issues to leave it, the package is slow as it must parse the contents into an AST and then statically analyze the tree looking for relevant calls tofs.readFile*. This overhead is unwanted, so I've removed it from our build process.