fix: Updated selector for the test networks#23986
Merged
Conversation
darkwing
reviewed
Apr 11, 2024
ui/selectors/selectors.js
Outdated
| getAllConnectedAccounts, | ||
| (connectedSubjectsForAllAddresses, identities, connectedAddresses) => { | ||
| const sitesList = {}; | ||
| console.log(sitesList) |
darkwing
reviewed
Apr 11, 2024
ui/selectors/selectors.js
Outdated
| ); | ||
| sitesList[siteKey].networkIconUrl = connectedNetwork.rpcPrefs.imageUrl; | ||
| // For the testnets, if we do not have an image, we will have a fallback string | ||
| sitesList[siteKey].networkIconUrl = connectedNetwork.rpcPrefs ? connectedNetwork.rpcPrefs.imageUrl : ''; |
Contributor
There was a problem hiding this comment.
Can this be:
connectedNetwork.rpcPrefs??.imageUrl || ''
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23986 +/- ##
===========================================
- Coverage 67.53% 67.53% -0.00%
===========================================
Files 1245 1245
Lines 48848 48848
Branches 12743 12746 +3
===========================================
- Hits 32989 32987 -2
- Misses 15859 15861 +2 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [f050198]
Page Load Metrics (1981 ± 736 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
darkwing
approved these changes
Apr 15, 2024
sahar-fehri
approved these changes
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to ensure that the permissions page renders list of all the permissions with the current networks. For a few networks, we don't have the rpcPrefs that was causing the siteKey nd the rpcPrefs to be undefined.
This PR also makes sure that the defined background color is there for the test networks that doesn't have a logo
Related issues
Fixes: #23812 #23793
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2024-04-12.at.12.00.01.AM.mov
After
Screen.Recording.2024-04-11.at.11.58.43.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist