fix: host permissions for cx.metamask.io#23958
Merged
cryptotavares merged 1 commit intodevelopfrom Apr 11, 2024
Merged
Conversation
When host permissions do not exist for a given domain, firefox sets cors policy to cross-origin. This was preventing getting the blockaid files from our cdn and thus making the feature unusable in firefox.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
pedronfigueiredo
approved these changes
Apr 11, 2024
digiwand
approved these changes
Apr 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23958 +/- ##
========================================
Coverage 67.46% 67.46%
========================================
Files 1244 1244
Lines 48777 48777
Branches 12724 12724
========================================
Hits 32907 32907
Misses 15870 15870 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [c478aa9]
Page Load Metrics (295 ± 287 ms)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When host permissions do not exist for a given domain, firefox sets cors policy to cross-origin.
This was preventing getting the blockaid files from our cdn and thus making the feature unusable in firefox.
This is fixed by adding
"https://*.cx.metamask.io/"to the manifest file permissions.Related issues
Fixes:
Manual testing steps
This is a deceptive request.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist