Skip to content

chore: bump snaps packages#23957

Merged
FrederikBolding merged 5 commits intodevelopfrom
fb/snaps-bump-v40
Apr 16, 2024
Merged

chore: bump snaps packages#23957
FrederikBolding merged 5 commits intodevelopfrom
fb/snaps-bump-v40

Conversation

@FrederikBolding
Copy link
Copy Markdown
Member

@FrederikBolding FrederikBolding commented Apr 11, 2024 •
edited
Loading

Description

Bump snaps packages to latest and handle breaking changes.

Summary of changes in the snaps deps:

  • Improve encryption performance by caching encryption keys
  • Remove access to on and removeListener on the ethereum object for Snaps
    • This functionality was already broken
  • Fixed a problem where unencrypted state would not be deleted when uninstalling a Snap
  • Allow form state to be null when triggering onUserInput
  • Fixed over-eager link validation being triggered on non-links
  • Add derivation path for Nimiq

@FrederikBolding FrederikBolding added the team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) label Apr 11, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 11, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.54%. Comparing base (f8b92ab) to head (e58ba3f).
Report is 15 commits behind head on develop.

❗ Current head e58ba3f differs from pull request most recent head b7cb4b1. Consider uploading reports for the commit b7cb4b1 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #23957      +/-   ##
===========================================
+ Coverage    67.52%   67.54%   +0.02%     
===========================================
  Files         1244     1244              
  Lines        48807    48789      -18     
  Branches     12747    12747              
===========================================
- Hits         32955    32953       -2     
+ Misses       15852    15836      -16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 11, 2024

Builds ready [044a2e0]
Page Load Metrics (833 ± 485 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint743071275326
domContentLoaded117329168
load6024188331010485
domInteractive117329168
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.47 KiB (0.07%)
  • ui: 0 Bytes (0.00%)
  • common: -452 Bytes (-0.01%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 11, 2024

Builds ready [30da833]
Page Load Metrics (793 ± 463 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint632771265527
domContentLoaded116228157
load512282793965463
domInteractive116228157
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.47 KiB (0.07%)
  • ui: 0 Bytes (0.00%)
  • common: -452 Bytes (-0.01%)

@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 12, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/snaps-controllers@7.0.1 None 0 1.24 MB metamaskbot
npm/@metamask/snaps-execution-environments@6.0.0 None 0 5.47 MB metamaskbot
npm/@metamask/snaps-rpc-methods@8.0.0 None 0 879 kB metamaskbot

🚮 Removed packages: npm/@metamask/snaps-execution-environments@5.0.4

View full report↗︎

@FrederikBolding FrederikBolding marked this pull request as ready for review April 15, 2024 07:49
@FrederikBolding FrederikBolding requested a review from a team as a code owner April 15, 2024 07:49
GuillaumeRx
GuillaumeRx previously approved these changes Apr 15, 2024
View reviewed changes
david0xd
david0xd previously approved these changes Apr 15, 2024
View reviewed changes
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 15, 2024

Builds ready [4aad908]
Page Load Metrics (1420 ± 583 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint772321394722
domContentLoaded14131402814
load60323014201214583
domInteractive14131402814
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.47 KiB (0.07%)
  • ui: 0 Bytes (0.00%)
  • common: -452 Bytes (-0.01%)

@FrederikBolding FrederikBolding dismissed stale reviews from david0xd and GuillaumeRx via f3e61ae April 15, 2024 14:07
david0xd
david0xd previously approved these changes Apr 15, 2024
View reviewed changes
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 15, 2024

Builds ready [f3e61ae]
Page Load Metrics (1236 ± 681 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint813841328139
domContentLoaded10119302713
load68338912361419681
domInteractive10119302713
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.47 KiB (0.07%)
  • ui: 0 Bytes (0.00%)
  • common: -452 Bytes (-0.01%)

GuillaumeRx
GuillaumeRx previously approved these changes Apr 15, 2024
View reviewed changes
@FrederikBolding FrederikBolding dismissed stale reviews from GuillaumeRx and david0xd via e58ba3f April 16, 2024 12:38
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 16, 2024

Builds ready [e58ba3f]
Page Load Metrics (1125 ± 616 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint733781307235
domContentLoaded1087342210
load58334311251283616
domInteractive1087342210
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.47 KiB (0.07%)
  • ui: 0 Bytes (0.00%)
  • common: -435 Bytes (-0.01%)

@bowensanders
Copy link
Copy Markdown
Contributor

bowensanders commented Apr 16, 2024

QA Passes ✅

@FrederikBolding FrederikBolding merged commit 62a8bd2 into develop Apr 16, 2024
@FrederikBolding FrederikBolding deleted the fb/snaps-bump-v40 branch April 16, 2024 20:56
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 16, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 16, 2024

Builds ready [b7cb4b1]
Page Load Metrics (1796 ± 615 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint713611416230
domContentLoaded995352010
load59334317961280615
domInteractive995352010
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.47 KiB (0.07%)
  • ui: 0 Bytes (0.00%)
  • common: -435 Bytes (-0.01%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@david0xd david0xd david0xd approved these changes

@GuillaumeRx GuillaumeRx GuillaumeRx approved these changes

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-11.16.0 Issue or pull request that will be included in release 11.16.0 team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@FrederikBolding @metamaskbot @bowensanders @david0xd @GuillaumeRx