Skip to content

fix: Updated avatar favicon props for single account disconnect toast#23935

Merged
NidhiKJha merged 1 commit intodevelopfrom
fix-23790
Apr 15, 2024
Merged

fix: Updated avatar favicon props for single account disconnect toast#23935
NidhiKJha merged 1 commit intodevelopfrom
fix-23790

Conversation

@NidhiKJha
Copy link
Copy Markdown
Member

@NidhiKJha NidhiKJha commented Apr 10, 2024

This PR ensures that when a single account is disconnected from the Dapp via connections. It shouldn't break the page and disconnects smoothle

Related issues

Fixes: #23790

Manual testing steps

  1. Run extension with Multichain flag
  2. Connect a single account to uniswap
  3. Go to connections page, click on disconnect account.
  4. It should disconnect the account

Screenshots/Recordings

Before

Screen.Recording.2024-04-10.at.5.58.14.PM.mov

After

Screen.Recording.2024-04-10.at.5.56.59.PM.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested a review from a team as a code owner April 10, 2024 12:28
@NidhiKJha NidhiKJha added team-core-extension-ux Core Extension UX team needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Apr 10, 2024
@NidhiKJha NidhiKJha changed the title fix:Updated avatar favicon props for single account disconnect toast fix:updated avatar favicon props for single account disconnect toast Apr 10, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 10, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.51%. Comparing base (0e90c73) to head (e94d04c).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #23935   +/-   ##
========================================
  Coverage    67.51%   67.51%           
========================================
  Files         1244     1244           
  Lines        48732    48732           
  Branches     12726    12726           
========================================
  Hits         32898    32898           
  Misses       15834    15834

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 10, 2024

Builds ready [e94d04c]
Page Load Metrics (493 ± 396 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6813894178
domContentLoaded95025126
load562352493825396
domInteractive95025126
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@NidhiKJha NidhiKJha changed the title fix:updated avatar favicon props for single account disconnect toast fix: Updated avatar favicon props for single account disconnect toast Apr 10, 2024
darkwing
darkwing approved these changes Apr 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works wonderfully!

@NidhiKJha NidhiKJha merged commit 833b601 into develop Apr 15, 2024
@NidhiKJha NidhiKJha deleted the fix-23790 branch April 15, 2024 07:04
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2024
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@darkwing darkwing darkwing approved these changes

@albertolive albertolive albertolive approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.16.0 Issue or pull request that will be included in release 11.16.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Multichain - "Disconnect" menu item from popup Connections page causes error

4 participants

@NidhiKJha @metamaskbot @darkwing @albertolive