fix: improve performance in account list and account connection components#23933
Merged
fix: improve performance in account list and account connection components#23933
Conversation
00b7bdd to
acded48
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #23933 +/- ##
===========================================
- Coverage 67.54% 67.52% -0.02%
===========================================
Files 1245 1245
Lines 48864 48869 +5
Branches 12744 12742 -2
===========================================
- Hits 33003 32995 -8
- Misses 15861 15874 +13 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [e80f64e]
Page Load Metrics (1550 ± 513 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [a6e4dfc]
Page Load Metrics (1465 ± 542 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
NidhiKJha
approved these changes
Apr 15, 2024
Member
NidhiKJha
left a comment
There was a problem hiding this comment.
LGTM! Verified locally, everything works
vthomas13
approved these changes
Apr 16, 2024
jpuri
approved these changes
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves performance in the account list and "account connection" components by no longer leveraging
getAddressConnectedSubjectMap. The selector in question is very computationally expensive to use and thus were causing performance problems for users with many accounts and many connected sites. This PR proposes usinggetPermittedAccountsForCurrentTabwhere possible and also introduces a memoized selectorisAccountConnectedToCurrentTabthat performantly can check for a given address.From local testing this seems to improve the experience.
Related issues
Fixes #23913