Skip to content

fix: implement revisions from QA#23921

Merged
micaelae merged 68 commits intomb843/swap-and-sendfrom
mb843/updates
May 8, 2024
Merged

fix: implement revisions from QA#23921
micaelae merged 68 commits intomb843/swap-and-sendfrom
mb843/updates

Conversation

@BZahory
Copy link
Copy Markdown
Contributor

@BZahory BZahory commented Apr 9, 2024 •
edited by github-actions bot
Loading

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@BZahory BZahory requested review from a team as code owners April 9, 2024 22:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@BZahory BZahory changed the base branch from develop to mb843/ui-2 April 9, 2024 22:27
@BZahory BZahory mentioned this pull request Apr 15, 2024
Merged
7 tasks
@BZahory BZahory force-pushed the mb843/updates branch 2 times, most recently from edaac08 to 0bbe887 Compare April 19, 2024 14:10
Base automatically changed from mb843/ui-2 to mb843/swap-and-send May 1, 2024 20:14
@BZahory BZahory force-pushed the mb843/updates branch 2 times, most recently from 46f46ae to ead5475 Compare May 6, 2024 12:03
@BZahory BZahory requested review from a team, brad-decker and kumavis as code owners May 6, 2024 12:03
@BZahory BZahory force-pushed the mb843/swap-and-send branch from f0455a3 to 0b2d7a4 Compare May 6, 2024 12:03
@BZahory BZahory force-pushed the mb843/updates branch 2 times, most recently from f012b0f to f3a1896 Compare May 6, 2024 12:07
micaelae
micaelae reviewed May 6, 2024
View reviewed changes
micaelae
micaelae reviewed May 6, 2024
View reviewed changes
micaelae
micaelae reviewed May 6, 2024
View reviewed changes
Bilal Zahory and others added 25 commits May 8, 2024 02:46
fix: check for non-zero decimal
fd73f29
chore: hide hex data field for swap+send
d8676dc
chore: add basic func dep (resolves MetaMask-planning#2349)
53cbe54
chore: add quote validation
0cfb1bc
refactor: reorder switch cases
0283fa6
refactor: change variable type
42836c8
chore: add loading animation
3e60403
chore: add undefined guard
7adcf82
feat: handle approvals
b86a802 
i lost this in a rebase i think
chore: update text formatting
032f52d
feat: update quote card styling
6863530 
add TOS
add fee text
add scroll anchor
fix: disable submit when loading
2ec06d6
refactor: pull out ref
a3dc94f
chore: prevent underline
701f3c5
fix: update time formatting
6a3f9e7
chore: update alignment
b54dfaa
feat: add disableUnderline to ButtonLink
9210c59
chore: remove underline on link
3d71bfc
fix: reduce fetches
3effbd6
@BZahory @ejwessel
fix: prevent user from sending 0 NFTs (#24420)
b5182f8 
Signed-off-by: Ethan Wessel <ethan.wessel@consensys.net>
Co-authored-by: Ethan Wessel <ethan.wessel@consensys.net>
docs: add task
eedb6f5
fix: show fiat 0 when balance 0
4208d91
chore: prevent bounce in styling
3f03da9
feat: auto-submit approval tx
a32d176
fix: remove unneeded padding
5dad560
@micaelae micaelae merged commit fbf3ac0 into mb843/swap-and-send May 8, 2024
@micaelae micaelae deleted the mb843/updates branch May 8, 2024 17:50
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@micaelae micaelae micaelae approved these changes

@kumavis kumavis Awaiting requested review from kumavis

@brad-decker brad-decker Awaiting requested review from brad-decker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BZahory @micaelae