Skip to content

chore: MMI adds custodian icons#23912

Merged
zone-live merged 9 commits intodevelopfrom
MMI-4876-custodian-icon
Apr 16, 2024
Merged

chore: MMI adds custodian icons#23912
zone-live merged 9 commits intodevelopfrom
MMI-4876-custodian-icon

Conversation

@zone-live
Copy link
Copy Markdown
Contributor

@zone-live zone-live commented Apr 9, 2024

Description

Adds custodian logo to the top bar, at the left of the address and also in the accounts list:

Screenshot 2024-04-09 at 15 12 26
Screenshot 2024-04-09 at 15 09 26

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live requested review from a team as code owners April 9, 2024 15:45
@zone-live zone-live added the mmi DEPRECATED: The product got sunset label Apr 9, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 9, 2024

Builds ready [18b47c6]
Page Load Metrics (1158 ± 531 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint643771167034
domContentLoaded95920146
load51270611581105531
domInteractive95920147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 49 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 69.08%. Comparing base (455a70b) to head (b2fcb27).
Report is 1 commits behind head on develop.

Files Patch % Lines
.../multichain/account-list-item/account-list-item.js 38.46% 8 Missing ⚠️
...onents/multichain/account-picker/account-picker.js 88.89% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #23912      +/-   ##
===========================================
- Coverage    69.09%   69.08%   -0.00%     
===========================================
  Files         1164     1164              
  Lines        44501    44518      +17     
  Branches     11889    11901      +12     
===========================================
+ Hits         30745    30755      +10     
- Misses       13756    13763       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 9, 2024

Builds ready [b2fcb27]
Page Load Metrics (87 ± 10 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6915899199
domContentLoaded115629147
load57155872110
domInteractive115529147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 49 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live changed the title chore: MMMI adds custodian icons chore: MMI adds custodian icons Apr 15, 2024
@zone-live zone-live merged commit 6ed9d04 into develop Apr 16, 2024
@zone-live zone-live deleted the MMI-4876-custodian-icon branch April 16, 2024 13:37
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@NidhiKJha NidhiKJha NidhiKJha approved these changes

+1 more reviewer

@albertolive albertolive albertolive approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mmi DEPRECATED: The product got sunset release-11.16.0 Issue or pull request that will be included in release 11.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zone-live @metamaskbot @albertolive @pedronfigueiredo @NidhiKJha