Skip to content

feat(23015): convert level 5 files for metamask-controller to ts#23888

Merged
DDDDDanica merged 1 commit intodevelopfrom
feature/23015
Apr 29, 2024
Merged

feat(23015): convert level 5 files for metamask-controller to ts#23888
DDDDDanica merged 1 commit intodevelopfrom
feature/23015

Conversation

@DDDDDanica
Copy link
Copy Markdown
Contributor

@DDDDDanica DDDDDanica commented Apr 8, 2024 •
edited by github-actions bot
Loading

Description

Fixes #23015

Converting the level 5 dependency files to typescript for contributing to metamask-controller.js.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@DDDDDanica DDDDDanica added team-extension-platform Extension Platform team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 8, 2024
@DDDDDanica DDDDDanica self-assigned this Apr 8, 2024
@DDDDDanica DDDDDanica requested a review from a team as a code owner April 8, 2024 12:31
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

zone-live
zone-live previously approved these changes Apr 8, 2024
View reviewed changes
albertolive
albertolive previously approved these changes Apr 8, 2024
View reviewed changes
@DDDDDanica DDDDDanica dismissed stale reviews from albertolive and zone-live via 75aeae8 April 8, 2024 12:42
@DDDDDanica DDDDDanica force-pushed the feature/23015 branch 10 times, most recently from bcb7a0a to d5c8ecf Compare April 9, 2024 16:06
@DDDDDanica
Copy link
Copy Markdown
Contributor Author

DDDDDanica commented Apr 9, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 9, 2024

Policies updated

@DDDDDanica DDDDDanica requested review from a team as code owners April 9, 2024 16:18
@DDDDDanica DDDDDanica force-pushed the feature/23015 branch 3 times, most recently from 53d643b to 3249776 Compare April 23, 2024 16:19
@DDDDDanica
Copy link
Copy Markdown
Contributor Author

DDDDDanica commented Apr 23, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 23, 2024

Policies updated

@DDDDDanica
Copy link
Copy Markdown
Contributor Author

DDDDDanica commented Apr 29, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 29, 2024

No policy changes

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 29, 2024

Builds ready [f27cc2c]
Page Load Metrics (1607 ± 671 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint701651012713
domContentLoaded11271652
load55326516071398671
domInteractive11271652
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 30 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.24%. Comparing base (01d6cb9) to head (f27cc2c).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #23888      +/-   ##
===========================================
- Coverage    67.24%   67.24%   -0.00%     
===========================================
  Files         1271     1271              
  Lines        49623    49620       -3     
  Branches     12908    12908              
===========================================
- Hits         33367    33364       -3     
  Misses       16256    16256

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DDDDDanica DDDDDanica merged commit c7f4821 into develop Apr 29, 2024
@DDDDDanica DDDDDanica deleted the feature/23015 branch April 29, 2024 09:00
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 29, 2024
@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zone-live zone-live zone-live approved these changes

@sahar-fehri sahar-fehri sahar-fehri approved these changes

+1 more reviewer

@albertolive albertolive albertolive left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@DDDDDanica DDDDDanica

Labels

release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-extension-platform Extension Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Convert partial level 5 files to typescript for contributing to metamask-controller.js

6 participants

@DDDDDanica @metamaskbot @zone-live @albertolive @sahar-fehri @gauthierpetetin