Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
a2f076f to
9fedf1c
Compare
19baaa0 to
a2c230e
Compare
Contributor
Author
|
The "Internal RPC-Error" failure is due to |
55c43ed to
0ef4860
Compare
darkwing
commented
Apr 17, 2024
Collaborator
Builds ready [1dcf5c5]
Page Load Metrics (1402 ± 714 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [6c42928]
Page Load Metrics (1423 ± 629 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [48e41ea]
Page Load Metrics (1279 ± 637 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23797 +/- ##
========================================
Coverage 67.46% 67.46%
========================================
Files 1258 1258
Lines 49235 49235
Branches 12818 12818
========================================
Hits 33213 33213
Misses 16022 16022 ☔ View full report in Codecov by Sentry. |
48e41ea to
84991e3
Compare
Collaborator
Builds ready [29062ce]
Page Load Metrics (1795 ± 685 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
EtherWizard33
approved these changes
Apr 24, 2024
| const { SMART_CONTRACTS } = require('../../seeder/smart-contracts'); | ||
|
|
||
| describe('Change assets', function () { | ||
| if (!process.env.MULTICHAIN) { |
Contributor
There was a problem hiding this comment.
nit: if the testing framework used has a function to skip the test it could be interesting to use it so maybe it could potentially show how many tests were skipped, in a summary at the end of the test run
NidhiKJha
approved these changes
Apr 26, 2024
jonybur
approved these changes
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When create E2Es for the new send flow, editing a transaction from sending an NFT to sending native currency was throwing an Internal JSON-RPC Error. After discussion with @matthewwalsh0 , using
0xas the gas reset is the solution.https://consensys.slack.com/archives/C03ETQA9EPK/p1713324192690549
Also adds an end to end test for ensuring that switching assets between a token to an NFT properly updates the asset.
Related issues
Fixes: N/A
Manual testing steps
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist