Skip to content

test: [Snaps E2E] add more snaps localization testing#23796

Merged
FrederikBolding merged 1 commit intodevelopfrom
bowen/locale-name
Apr 15, 2024
Merged

test: [Snaps E2E] add more snaps localization testing#23796
FrederikBolding merged 1 commit intodevelopfrom
bowen/locale-name

Conversation

@bowensanders
Copy link
Copy Markdown
Contributor

@bowensanders bowensanders commented Mar 28, 2024 •
edited
Loading

Description

This PR adds checks for snap name localization to the snaps localization E2E test.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1653

Manual testing steps

  1. Run this as a single test locally.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bowensanders bowensanders added area-snaps e2e-test End to end test for the MetaMask extension team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) labels Mar 28, 2024
@bowensanders bowensanders self-assigned this Mar 28, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 28, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.00%. Comparing base (b2d843f) to head (9fe194c).
Report is 6 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #23796      +/-   ##
===========================================
- Coverage    69.13%   69.00%   -0.12%     
===========================================
  Files         1160     1164       +4     
  Lines        44275    44436     +161     
  Branches     11844    11870      +26     
===========================================
+ Hits         30606    30662      +56     
- Misses       13669    13774     +105

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bowensanders bowensanders marked this pull request as ready for review March 28, 2024 23:53
@bowensanders bowensanders requested a review from a team as a code owner March 28, 2024 23:53
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 28, 2024

Builds ready [9fe194c]
Page Load Metrics (367 ± 321 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint651441012210
domContentLoaded96025157
load492026367668321
domInteractive96025157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@FrederikBolding FrederikBolding merged commit 91d5d4e into develop Apr 15, 2024
@FrederikBolding FrederikBolding deleted the bowen/locale-name branch April 15, 2024 09:45
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2024
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@FrederikBolding FrederikBolding FrederikBolding approved these changes

@GuillaumeRx GuillaumeRx GuillaumeRx approved these changes

Assignees

@bowensanders bowensanders

Labels

area-snaps e2e-test End to end test for the MetaMask extension release-11.16.0 Issue or pull request that will be included in release 11.16.0 team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bowensanders @metamaskbot @FrederikBolding @GuillaumeRx