chore: adds GH action for MMI by zone-live · Pull Request #23778 · MetaMask/metamask-extension

zone-live · 2024-03-28T09:13:55Z

Description

Creates a GH action to automatically notify MMI team members in order to have immediate visibility of what’s to come and test/review.

Meaning, it will automatically notify us to our extension slack channel, when a PR with the "team-mmi" tag is merged to develop.

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-03-28T09:14:09Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-04-01T10:35:26Z

Builds ready [9455a78]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (548 ± 457 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	365	114	73	35
		domContentLoaded	9	44	18	8	4
		load	55	2767	548	952	457
		domInteractive	9	44	18	8	4

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2024-04-01T10:35:33Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.59%. Comparing base (01a4d60) to head (983c497).
Report is 5 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #23778   +/-   ##
========================================
  Coverage    67.59%   67.59%           
========================================
  Files         1245     1245           
  Lines        48834    48834           
  Branches     12762    12762           
========================================
  Hits         33008    33008           
  Misses       15826    15826

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/add-mmi-reviewer-and-notify.yml

Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>

metamaskbot · 2024-04-02T17:48:12Z

Builds ready [1686f4c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (920 ± 537 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	354	151	69	33
		domContentLoaded	10	75	34	21	10
		load	55	2879	920	1119	537
		domInteractive	10	75	34	21	10

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-04-03T12:04:09Z

Builds ready [fffd2e0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (810 ± 479 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	329	124	56	27
		domContentLoaded	12	58	24	12	6
		load	59	2464	810	998	479
		domInteractive	12	58	24	12	6

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-04-04T13:18:05Z

Builds ready [d27db18]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1056 ± 581 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	213	125	40	19
		domContentLoaded	11	69	26	14	7
		load	58	3373	1056	1209	581
		domInteractive	11	69	26	14	7

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-04-12T15:56:50Z

Builds ready [66fd713]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1252 ± 506 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	64	299	133	53	25
		domContentLoaded	9	89	36	24	11
		load	52	2396	1252	1053	506
		domInteractive	9	89	36	24	11

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

…Mask/metamask-extension into MMI-4847-gh-action-autotag-mmi-team

metamaskbot · 2024-04-15T11:04:36Z

Builds ready [fad9312]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1152 ± 619 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	82	322	145	71	34
		domContentLoaded	12	100	27	20	9
		load	67	3011	1152	1290	619
		domInteractive	12	100	27	20	9

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-04-16T10:29:00Z

Builds ready [f106a1e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1442 ± 662 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	402	156	95	46
		domContentLoaded	10	53	22	10	5
		load	60	3520	1442	1378	662
		domInteractive	10	53	22	10	5

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

.github/workflows/add-mmi-reviewer-and-notify.yml

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>

metamaskbot · 2024-04-16T14:31:38Z

Builds ready [983c497]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (728 ± 552 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	63	155	94	24	12
		domContentLoaded	9	61	22	14	7
		load	52	3183	728	1149	552
		domInteractive	9	61	22	14	7

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

chore: adds gh actions

44a4829

zone-live added the mmi DEPRECATED: The product got sunset label Mar 28, 2024

zone-live and others added 2 commits March 28, 2024 13:44

chore: updates secret name to MMI_LABEL_SLACK_WEBHOOK_URL

92e94f5

Merge branch 'develop' into MMI-4847-gh-action-autotag-mmi-team

9455a78

zone-live marked this pull request as ready for review April 1, 2024 11:03

zone-live requested a review from a team as a code owner April 1, 2024 11:03

zone-live requested a review from Gudahtt April 1, 2024 11:03

davidmurdoch reviewed Apr 2, 2024

View reviewed changes

.github/workflows/add-mmi-reviewer-and-notify.yml Outdated Show resolved Hide resolved

.github/workflows/add-mmi-reviewer-and-notify.yml Outdated Show resolved Hide resolved

zone-live and others added 2 commits April 2, 2024 17:15

Update .github/workflows/add-mmi-reviewer-and-notify.yml

9207c7a

Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>

chore: updates reviewers to team_reviewers

1686f4c

zone-live added mmi DEPRECATED: The product got sunset and removed mmi DEPRECATED: The product got sunset labels Apr 3, 2024

zone-live and others added 13 commits April 3, 2024 10:55

chore: test on pull_request

f762757

chore: test on pull_request

3c335d0

chore: test and update

ab2aa1c

Merge branch 'develop' into MMI-4847-gh-action-autotag-mmi-team

0e05204

chore: update

24b4e15

chore: update

7fcff6e

chore: update

793d1c0

chore: update action to use slackapi

b7d1ffb

chore: update action to use slackapi

e40e80d

chore: update action

907c7a1

chore: use slackAPI version 007b2c3c751a190b6f0f040e47ed024deaa72844

adb968f

chore: just me sadly, for now

dfb5e93

chore: back to the team, because It cant be me alone

fffd2e0

zone-live added 5 commits April 4, 2024 13:40

chore: test

051ff43

chore: test

6b8cd0f

chore: test

b5cb123

chore: test

e1b0a79

chore: test

d27db18

zone-live and others added 7 commits April 12, 2024 16:19

chore: test notify step

5aa2859

chore: test github.repository

3083fec

chore: test github.repository

293a8f5

chore: test github.repository

0825147

chore: version fix

b094f8f

chore: clean up

ea5fb3d

Merge branch 'develop' into MMI-4847-gh-action-autotag-mmi-team

66fd713

zone-live added 2 commits April 15, 2024 11:40

chore: passing url in payload text

4c56591

Merge branch 'MMI-4847-gh-action-autotag-mmi-team' of github.com:Meta…

fad9312

…Mask/metamask-extension into MMI-4847-gh-action-autotag-mmi-team

Merge branch 'develop' into MMI-4847-gh-action-autotag-mmi-team

f106a1e

legobeat reviewed Apr 16, 2024

View reviewed changes

.github/workflows/add-mmi-reviewer-and-notify.yml Outdated Show resolved Hide resolved

Update .github/workflows/add-mmi-reviewer-and-notify.yml

983c497

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>

zone-live requested a review from davidmurdoch April 16, 2024 15:23

davidmurdoch approved these changes Apr 16, 2024

View reviewed changes

albertolive approved these changes Apr 17, 2024

View reviewed changes

zone-live merged commit 48a7969 into develop Apr 17, 2024

zone-live deleted the MMI-4847-gh-action-autotag-mmi-team branch April 17, 2024 09:33

github-actions bot locked and limited conversation to collaborators Apr 17, 2024

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 17, 2024

metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: adds GH action for MMI#23778

chore: adds GH action for MMI#23778
zone-live merged 39 commits intodevelopfrom
MMI-4847-gh-action-autotag-mmi-team

zone-live commented Mar 28, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Mar 28, 2024

Uh oh!

metamaskbot commented Apr 1, 2024

Uh oh!

codecov bot commented Apr 1, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Apr 2, 2024

Uh oh!

metamaskbot commented Apr 3, 2024

Uh oh!

metamaskbot commented Apr 4, 2024

Uh oh!

metamaskbot commented Apr 12, 2024

Uh oh!

metamaskbot commented Apr 15, 2024

Uh oh!

metamaskbot commented Apr 16, 2024

Uh oh!

Uh oh!

metamaskbot commented Apr 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

zone-live commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 28, 2024

Uh oh!

metamaskbot commented Apr 1, 2024

Uh oh!

codecov bot commented Apr 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Apr 2, 2024

Uh oh!

metamaskbot commented Apr 3, 2024

Uh oh!

metamaskbot commented Apr 4, 2024

Uh oh!

metamaskbot commented Apr 12, 2024

Uh oh!

metamaskbot commented Apr 15, 2024

Uh oh!

metamaskbot commented Apr 16, 2024

Uh oh!

Uh oh!

metamaskbot commented Apr 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

zone-live commented Mar 28, 2024 •

edited

Loading

codecov bot commented Apr 1, 2024 •

edited

Loading