fix: display of reverse string in signature request message#23751
Merged
fix: display of reverse string in signature request message#23751
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jpuri
commented
Mar 27, 2024
| <ConfirmInfoRowAddress address={value} /> | ||
| ) : ( | ||
| <ConfirmInfoRowText text={value} /> | ||
| <ConfirmInfoRowText text={sanitizeString(value)} /> |
Contributor
Author
There was a problem hiding this comment.
I need to do some fixes in this component to be able to unit test cover it. It will be in a followup PR for this issue: https://app.zenhub.com/workspaces/-confirmations-secure-ux-6245e6e2348677001213b8d2/issues/gh/metamask/metamask-extension/23689
Collaborator
Builds ready [951898b]
Page Load Metrics (730 ± 463 ms)
Bundle size diffs
|
pedronfigueiredo
approved these changes
Mar 27, 2024
Collaborator
Builds ready [78749e2]
Page Load Metrics (950 ± 513 ms)
Bundle size diffs
|
segun
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix display of reverse string in signature request message.
Related issues
Fixes: #23691
Manual testing steps
For reproducing, open the console and paste this (changing the address to your connected address)
await window.ethereum.request({"method":"personal_sign","params":["0x07Be9763a718C0539017E2Ab6fC42853b4aEeb6B", "Sign into \u202E EVIL"],"id":1})
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist