Skip to content

fix: chain name passed to report false positive blockaid requests#23750

Merged
jpuri merged 1 commit intodevelopfrom
base_chainname_fix
Mar 27, 2024
Merged

fix: chain name passed to report false positive blockaid requests#23750
jpuri merged 1 commit intodevelopfrom
base_chainname_fix

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented Mar 27, 2024

Description

Fix chain name passed to false positive form.

Related issues

Fixes: #23724

Manual testing steps

  1. Select Base network
  2. Trigger a malicious tx from the test dapp
  3. Click Report false positive --> chain name is empty

Screenshots/Recordings

Screenshot 2024-03-27 at 11 01 20 AM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 27, 2024
@jpuri jpuri requested a review from a team as a code owner March 27, 2024 05:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 27, 2024

Builds ready [e0d3e31]
Page Load Metrics (1004 ± 548 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint793661386933
domContentLoaded168328199
load61295610041141548
domInteractive168328199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 11 Bytes (0.00%)

@jpuri jpuri merged commit 3aa7bed into develop Mar 27, 2024
@jpuri jpuri deleted the base_chainname_fix branch March 27, 2024 08:25
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
@metamaskbot metamaskbot added the release-11.15.0 Issue or pull request that will be included in release 11.15.0 label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@segun segun segun approved these changes

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.15.0 Issue or pull request that will be included in release 11.15.0 team-confirmations-secure-ux-PR PRs from the confirmations team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: PPOM - False Positives: Chain Name is not displayed for Base network on report false positive portal

4 participants

@jpuri @metamaskbot @segun @blackdevelopa